Filecopy GUI error message and kdialog progress bar fixes #476

rustybird · 2023-12-02T18:29:54Z

Fixes QubesOS/qubes-issues#8723
Fixes QubesOS/qubes-issues#8738

In practice kdialog wasn't used, because the package was built without USE_KDIALOG being defined. Fixes QubesOS/qubes-issues#8738

A while ago qfile-agent was changed to show graphical error messages (in addition to stderr messages) only if PROGRESS_TYPE=gui is set. Set it even if a progress bar window is not being shown, e.g. if the total estimated size is 0. Fixes QubesOS/qubes-issues#8738

The new syntax has existed for more than six years: https://invent.kde.org/utilities/kdialog/-/commit/d72ab46df8879024cda620beec9da71a674873dc#5d61d07d60f0444023012a7c0902c123179f8bdd

The estimated total size in bytes can be too large to use as kdialog's maximum. Use the default 100 instead and calculate a percentage for the current position, like in progress_zenity(). Fixes QubesOS/qubes-issues#8723

codecov · 2023-12-02T19:02:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a29270) 69.89% compared to head (0ad16b2) 69.89%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   69.89%   69.89%           
=======================================
  Files           3        3           
  Lines         475      475           
=======================================
  Hits          332      332           
  Misses        143      143

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qubesos-bot · 2023-12-03T09:12:58Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023120304-4.2&flavor=pull-requests

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023111404-4.2&flavor=update

system_tests_basic_vm_qrexec_gui_zfs
- TC_20_AudioVM_PipeWire_debian-12-xfce-pool: test_226_audio_playback_pipewire (failure)
  AssertionError: Command 'pw-play --format=f32 --rate=44100 --channe...
system_tests_basic_vm_qrexec_gui_btrfs
- TC_20_AudioVM_Pulse_debian-12-xfce-pool: test_222_audio_rec_unmuted_pulseaudio (error)
  qubes.exc.QubesVMError: Failed to attach audio input from dom0 to t...
- TC_20_AudioVM_Pulse_fedora-38-xfce-pool: test_223_audio_play_hvm (failure)
  AssertionError: too short audio, expected 10s, got 9.13918367346938...
system_tests_basic_vm_qrexec_gui@hw1
- TC_20_AudioVM_PipeWire_debian-12-xfce: test_226_audio_playback_pipewire (failure)
  AssertionError: Command 'pw-play --format=f32 --rate=44100 --channe...
system_tests_basic_vm_qrexec_gui
- TC_20_NonAudio_debian-12-xfce: test_000_start_shutdown (error + timed out)
  qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...

Failed tests

7 failures

system_tests_splitgpg
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_basic_vm_qrexec_gui_zfs
- TC_20_AudioVM_PipeWire_debian-12-xfce-pool: test_226_audio_playback_pipewire (failure)
  AssertionError: Command 'pw-play --format=f32 --rate=44100 --channe...
system_tests_basic_vm_qrexec_gui_btrfs
- TC_20_AudioVM_Pulse_debian-12-xfce-pool: test_222_audio_rec_unmuted_pulseaudio (error)
  qubes.exc.QubesVMError: Failed to attach audio input from dom0 to t...
- TC_20_AudioVM_Pulse_fedora-38-xfce-pool: test_223_audio_play_hvm (failure)
  AssertionError: too short audio, expected 10s, got 9.13918367346938...
system_tests_basic_vm_qrexec_gui@hw1
- TC_20_AudioVM_PipeWire_debian-12-xfce: test_226_audio_playback_pipewire (failure)
  AssertionError: Command 'pw-play --format=f32 --rate=44100 --channe...
- [unstable] TC_20_NonAudio_whonix-gateway-17: test_300_bug_1028_gui_memory_pinning (failure)
  AssertionError: Dom0 window doesn't match VM window content, saved ...
system_tests_basic_vm_qrexec_gui
- TC_20_NonAudio_debian-12-xfce: test_000_start_shutdown (error + timed out)
  qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/85616#dependencies

6 fixed

system_tests_pvgrub_salt_storage
- TC_41_HVMGrub_fedora-38-xfce: test_000_standalone_vm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- TC_41_HVMGrub_fedora-38-xfce: test_010_template_based_vm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
system_tests_splitgpg
- TC_10_Thunderbird_fedora-38-xfce: test_000_send_receive_default (failure)
  Exception: Failed to send message with error 'unknown'
system_tests_devices
- TC_00_List_debian-12-xfce: test_001_list_loop_mounted (failure)
  AssertionError: Device test-inst-vm:loop0 (/tmp/test.img) should no...
system_tests_basic_vm_qrexec_gui_zfs
- TC_20_AudioVM_Pulse_debian-12-xfce-pool: test_223_audio_play_hvm (failure)
  AssertionError: too short audio, expected 10s, got 9.35730158730158...
system_tests_basic_vm_qrexec_gui_ext4
- TC_20_AudioVM_Pulse_debian-12-xfce-pool: test_222_audio_rec_unmuted_pulseaudio (error)
  qubes.exc.QubesVMError: Failed to attach audio input from dom0 to t...

Unstable tests

system_tests_splitgpg
TC_10_Thunderbird_debian-12-xfce/test_000_send_receive_default (1/5 times with errors)
- job 84710 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
TC_10_Thunderbird_fedora-38-xfce/test_000_send_receive_default (2/5 times with errors)
- job 84710 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- job 85646 Exception: Failed to send message with error 'unknown'
TC_10_Thunderbird_whonix-workstation-17/test_000_send_receive_default (1/5 times with errors)
- job 84710 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
TC_10_Thunderbird_debian-12-xfce/test_010_send_receive_inline_signed_only (1/5 times with errors)
- job 84710 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
TC_10_Thunderbird_fedora-38-xfce/test_010_send_receive_inline_signed_only (1/5 times with errors)
- job 84710 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
TC_10_Thunderbird_whonix-workstation-17/test_010_send_receive_inline_signed_only (1/5 times with errors)
- job 84710 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
TC_10_Thunderbird_debian-12-xfce/test_020_send_receive_inline_with_attachment (2/5 times with errors)
- job 84710 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- job 85328 Exception: Failed to send message with error 'unknown'
TC_10_Thunderbird_fedora-38-xfce/test_020_send_receive_inline_with_attachment (3/5 times with errors)
- job 84710 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- job 85117 Exception: Failed to send message with error 'unknown'
- job 86105 Exception: Failed to send message with error 'unknown'
system_tests_usbproxy
TC_20_USBProxy_core3_debian-12-xfce/test_070_attach_not_installed_front (1/5 times with errors)
- job 85091 qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...
TC_20_USBProxy_core3_whonix-gateway-17/test_070_attach_not_installed_front (1/5 times with errors)
- job 85302 qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...
TC_20_USBProxy_core3_whonix-workstation-17/test_070_attach_not_installed_front (1/5 times with errors)
- job 84684 qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...
system_tests_devices
TC_00_List_debian-12-xfce/test_001_list_loop_mounted (3/5 times with errors)
- job 84700 AssertionError: Device test-inst-vm:loop0 (/tmp/test.img) should no...
- job 85318 AssertionError: Device test-inst-vm:loop0 (/tmp/test.img) should no...
- job 85636 AssertionError: Device test-inst-vm:loop0 (/tmp/test.img) should no...
system_tests_whonix@hw1
whonix_torbrowser/ (1/5 times with errors)
- job 84081 None
whonix_torbrowser/ (1/5 times with errors)
- job 84081 None
whonix_torbrowser/Failed (1/5 times with errors)
- job 84081 # Test died: no candidate needle with tag(s) 'desktop-clear' matche...
system_tests_basic_vm_qrexec_gui_zfs
TC_00_Basic/test_120_start_standalone_with_cdrom_dom0 (1/5 times with errors)
- job 85304 AssertionError: 1 != 0 : b'Timeout waiting for dom0:loop4 device to...
TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_220_audio_play_pulseaudio (1/5 times with errors)
- job 84686 AssertionError: Command 'paplay --format=float32le --rate=44100 --c...
TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_223_audio_play_hvm (1/5 times with errors)
- job 85622 AssertionError: too short audio, expected 10s, got 9.35730158730158...
system_tests_basic_vm_qrexec_gui_ext4
TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_222_audio_rec_unmuted_pulseaudio (1/5 times with errors)
- job 85648 qubes.exc.QubesVMError: Failed to attach audio input from dom0 to t...
system_tests_basic_vm_qrexec_gui_xfs
TC_20_NonAudio_whonix-gateway-17-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
- job 86094 AssertionError: Dom0 window doesn't match VM window content, saved ...
system_tests_basic_vm_qrexec_gui@hw1
TC_20_AudioVM_Pulse_debian-12-xfce/test_220_audio_play_pulseaudio (1/5 times with errors)
- job 86091 AssertionError: Command 'paplay --format=float32le --rate=44100 --c...
TC_20_NonAudio_whonix-gateway-17/test_300_bug_1028_gui_memory_pinning (2/5 times with errors)
- job 85314 AssertionError: Dom0 window doesn't match VM window content, saved ...
- job 86091 AssertionError: Dom0 window doesn't match VM window content, saved ...
system_tests_basic_vm_qrexec_gui
TC_20_AudioVM_Pulse_debian-12-xfce/test_220_audio_play_pulseaudio (1/5 times with errors)
- job 86091 AssertionError: Command 'paplay --format=float32le --rate=44100 --c...
TC_20_NonAudio_whonix-gateway-17/test_300_bug_1028_gui_memory_pinning (2/5 times with errors)
- job 85314 AssertionError: Dom0 window doesn't match VM window content, saved ...
- job 86091 AssertionError: Dom0 window doesn't match VM window content, saved ...
system_tests_whonix
whonix_torbrowser/ (1/5 times with errors)
- job 84081 None
whonix_torbrowser/ (1/5 times with errors)
- job 84081 None
whonix_torbrowser/Failed (1/5 times with errors)
- job 84081 # Test died: no candidate needle with tag(s) 'desktop-clear' matche...

rustybird added 5 commits December 2, 2023 18:13

gui-fatal: dynamically fall back on kdialog after trying zenity

dac51d1

In practice kdialog wasn't used, because the package was built without USE_KDIALOG being defined. Fixes QubesOS/qubes-issues#8738

qvm-copy-to-vm.gnome: update qdbus syntax

6c31daf

The new syntax has existed for more than six years: https://invent.kde.org/utilities/kdialog/-/commit/d72ab46df8879024cda620beec9da71a674873dc#5d61d07d60f0444023012a7c0902c123179f8bdd

qvm-copy-to-vm.gnome: qdbus can have a -qt5/6 suffix (Fedora)

5043a45

qvm-copy-to-vm.gnome: fix progress_kdialog() for large transfers

0ad16b2

The estimated total size in bytes can be too large to use as kdialog's maximum. Use the default 100 instead and calculate a percentage for the current position, like in progress_zenity(). Fixes QubesOS/qubes-issues#8723

rustybird force-pushed the gui-filecopy-progress-and-errors branch from 14357a2 to 0ad16b2 Compare December 2, 2023 19:03

marmarek added the openqa-pending label Dec 2, 2023

marmarek approved these changes Dec 4, 2023

View reviewed changes

marmarek merged commit 4ec4c79 into QubesOS:main Dec 4, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Filecopy GUI error message and kdialog progress bar fixes #476

Filecopy GUI error message and kdialog progress bar fixes #476

rustybird commented Dec 2, 2023

codecov bot commented Dec 2, 2023 •

edited

Loading

qubesos-bot commented Dec 3, 2023 •

edited

Loading

Filecopy GUI error message and kdialog progress bar fixes #476

Filecopy GUI error message and kdialog progress bar fixes #476

Conversation

rustybird commented Dec 2, 2023

codecov bot commented Dec 2, 2023 • edited Loading

Codecov Report

qubesos-bot commented Dec 3, 2023 • edited Loading

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

codecov bot commented Dec 2, 2023 •

edited

Loading

qubesos-bot commented Dec 3, 2023 •

edited

Loading