-
-
Notifications
You must be signed in to change notification settings - Fork 109
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
There are a couple of issues with this renaming: 1. When enabled, the interface name cannot be prediced until it actually happens. This breaks waiting for the device to appear in qubes-network-uplink.service. 2. Setting SYSTEMD_WANTS on a device that gets renamed seems to not work (is the variable bound to the old device name?). This breaks dynamic network attach (see 99-qubes-network.rules). So, disable it completely for Xen devices, at least for now. This may pose some issues (or rather - rollback fix attempt) for VMs with both physical devices and Xen netfront device(s), but this is extremely rare case that nobody complained about before. Fixes QubesOS/qubes-issues#7284
- Loading branch information
Showing
4 changed files
with
17 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ lib/systemd/system/qubes-network.service | |
lib/systemd/system/qubes-network-uplink.service | ||
lib/systemd/system/[email protected] | ||
lib/systemd/system/qubes-updates-proxy.service | ||
lib/systemd/network/80-qubes-vif.link | ||
usr/lib/qubes/init/network-proxy-setup.sh | ||
usr/lib/qubes/init/network-proxy-stop.sh | ||
usr/lib/qubes/init/network-uplink-wait.sh | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -828,6 +828,7 @@ rm -f %{name}-%{version} | |
/usr/lib/systemd/system/qubes-network-uplink.service | ||
/usr/lib/systemd/system/[email protected] | ||
/usr/lib/systemd/system/qubes-updates-proxy.service | ||
/usr/lib/systemd/network/80-qubes-vif.link | ||
/usr/lib/qubes/init/network-proxy-setup.sh | ||
/usr/lib/qubes/init/network-proxy-stop.sh | ||
/usr/lib/qubes/init/network-uplink-wait.sh | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Disable renaming of Xen netfront interfaces, to avoid race conditions during | ||
# network configuration. systemd / udevd does not provide any way to | ||
# synchronize against interface rename operation when the device is not | ||
# detected yet. | ||
# Furthermore, setting SYSTEMD_WANTS in udev seems to not work when interface | ||
# is renamed. | ||
# See https://github.com/QubesOS/qubes-issues/issues/7284 for details. | ||
|
||
[Match] | ||
Driver=vif | ||
|
||
[Link] | ||
NamePolicy= |