Skip to content

Commit

Permalink
rpm: use the install target in boot/Makefile
Browse files Browse the repository at this point in the history
Fix the target to install file into /etc/default (it's not grub.d file).
And then don't open-code it in the spec file.
No functional change.

(cherry picked from commit 33e30a1)
  • Loading branch information
marmarek committed Dec 27, 2024
1 parent e42183b commit 28ae00e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 3 additions & 2 deletions boot/Makefile
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
LIBDIR ?= /usr/lib
SYSCONFDIR ?= /etc
GRUBCONFDIR ?= $(SYSCONFDIR)/grub.d
GRUBCONFDIR ?= $(SYSCONFDIR)/default
DRACUTCONFDIR ?= $(LIBDIR)/dracut/dracut.conf.d
GRUBCFGNAME ?= grub.qubes

.PHONY: install

install:
install -D -m 0644 grub.qubes $(DESTDIR)$(GRUBCONFDIR)/30_qubes
install -D -m 0644 grub.qubes $(DESTDIR)$(GRUBCONFDIR)/$(GRUBCFGNAME)
install -D -m 0644 dracut-qubes.conf $(DESTDIR)$(DRACUTCONFDIR)/30-qubes.conf
4 changes: 1 addition & 3 deletions rpm_spec/core-agent.spec.in
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,7 @@ usermod -L root

make install-vm PYTHON=%{__python3} "DESTDIR=$RPM_BUILD_ROOT" SYSTEM_DROPIN_DIR=%{_unitdir} SYSLIBDIR=/usr/lib ENABLE_SELINUX=%with_selinux
make -C app-menu DESTDIR=$RPM_BUILD_ROOT install
make -C boot DESTDIR=$RPM_BUILD_ROOT install
make -C boot/redhat DESTDIR=$RPM_BUILD_ROOT install
make -C config-overrides DESTDIR=$RPM_BUILD_ROOT install
make -C filesystem DESTDIR=$RPM_BUILD_ROOT install
Expand Down Expand Up @@ -520,9 +521,6 @@ sed -i \
$RPM_BUILD_ROOT/etc/yum.repos.d/qubes-*.repo
%endif

install -D -m 0644 boot/dracut-qubes.conf $RPM_BUILD_ROOT/usr/lib/dracut/dracut.conf.d/30-qubes.conf
install -D -m 0644 boot/grub.qubes $RPM_BUILD_ROOT/etc/default/grub.qubes

%if ! %with_sysvinit
rm -rf $RPM_BUILD_ROOT/etc/init.d/qubes-* $RPM_BUILD_ROOT/etc/sysconfig/modules/qubes-core.modules
%endif
Expand Down

0 comments on commit 28ae00e

Please sign in to comment.