Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message if new VM Name starts with illegal characters #606

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

alimirjamali
Copy link
Contributor

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.35%. Comparing base (3362ffc) to head (51a425b).
Report is 5 commits behind head on main.

Files Patch % Lines
qubes/vm/__init__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   69.35%   69.35%           
=======================================
  Files          58       58           
  Lines       11919    11923    +4     
=======================================
+ Hits         8266     8269    +3     
- Misses       3653     3654    +1     
Flag Coverage Δ
unittests 69.35% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alimirjamali
Copy link
Contributor Author

alimirjamali commented Jul 5, 2024

It appears that I have to write unit tests for this PR.

Should this be added to the existing Unit Test test_334_vm_create_invalid_name or a new one?

@marmarek
Copy link
Member

marmarek commented Jul 5, 2024

Should this be added to the existing Unit Test test_334_vm_create_invalid_name or a new one?

Both options are okay (if existing one, just make sure to use separate with blocks).

@alimirjamali
Copy link
Contributor Author

Both options are okay (if existing one, just make sure to use separate with blocks).

Done. Waiting for CI/CD pipeline

@marmarek marmarek merged commit 71f7ca6 into QubesOS:main Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading error message if VM name starts with a character in _0123456789-
2 participants