Skip to content

Commit

Permalink
Fix docstrings formatting
Browse files Browse the repository at this point in the history
Fix warnings/errors reported by Sphinx
  • Loading branch information
marmarek committed Jul 4, 2017
1 parent e7f717e commit f393ce6
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 16 deletions.
4 changes: 2 additions & 2 deletions qubes/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,8 @@ def sanitize(self, *, untrusted_newvalue):
setter. Can raise QubesValueError if the value is invalid.
:param untrusted_newvalue: value to be validated
:return sanitized value
:raises qubes.exc.QubesValueError
:return: sanitized value
:raises: qubes.exc.QubesValueError
'''
# do not treat type='str' as sufficient validation
if self.type is not None and self.type is not str:
Expand Down
5 changes: 3 additions & 2 deletions qubes/backup.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ def load(self, untrusted_header_text):
:param untrusted_header_text: header content
:type untrusted_header_text: basestring
.. warning::
This function may be exposed to not yet verified header,
so is security critical.
Expand Down Expand Up @@ -864,9 +865,9 @@ def handle_streams(stream_in, streams_out, processes, size_limit=None,
:param processes: dict of subprocess.Popen objects to monitor
:param size_limit: int maximum data amount to process
:param progress_callback: callable function to report progress, will be
given copied data size (it should accumulate internally)
given copied data size (it should accumulate internally)
:return: failed process name, failed stream name, "size_limit" or None (
no error)
no error)
'''
buffer_size = 409600
bytes_copied = 0
Expand Down
4 changes: 2 additions & 2 deletions qubes/dochelpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def check_undocumented_arguments(self, ignored_options=None):
While the documentation talks about a
'SparseNodeVisitor.depart_document()' function, this function does
not exists. (For details see implementation of
:py:method:`NodeVisitor.dispatch_departure()`) So we need to
:py:meth:`NodeVisitor.dispatch_departure()`) So we need to
manually call this.
'''
if ignored_options is None:
Expand Down Expand Up @@ -316,7 +316,7 @@ def check_undocumented_sub_commands(self):
While the documentation talks about a
'SparseNodeVisitor.depart_document()' function, this function does
not exists. (For details see implementation of
:py:method:`NodeVisitor.dispatch_departure()`) So we need to
:py:meth:`NodeVisitor.dispatch_departure()`) So we need to
manually call this.
'''
if self.sub_commands:
Expand Down
2 changes: 1 addition & 1 deletion qubes/tests/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def expectedFailureIfTemplate(templates):
Decorator for marking specific test as expected to fail only for some
templates. Template name is compared as substring, so 'whonix' will
handle both 'whonix-ws' and 'whonix-gw'.
templates can be either a single string, or an iterable
templates can be either a single string, or an iterable
"""
def decorator(func):
@functools.wraps(func)
Expand Down
12 changes: 7 additions & 5 deletions qubes/tools/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,11 +303,13 @@ class QubesArgumentParser(argparse.ArgumentParser):
:py:class:`qubes.Qubes` object, just add argument for custom xml file
:param bool want_force_root: add ``--force-root`` option
:param mixed vmname_nargs: The number of ``VMNAME`` arguments that should be
consumed. Values include:
- N (an integer) consumes N arguments (and produces a list)
- '?' consumes zero or one arguments
- '*' consumes zero or more arguments (and produces a list)
- '+' consumes one or more arguments (and produces a list)
consumed. Values include:
- N (an integer) consumes N arguments (and produces a list)
- '?' consumes zero or one arguments
- '*' consumes zero or more arguments (and produces a list)
- '+' consumes one or more arguments (and produces a list)
*kwargs* are passed to :py:class:`argparser.ArgumentParser`.
Currenty supported options:
Expand Down
8 changes: 4 additions & 4 deletions qubes/vm/qubesvm.py
Original file line number Diff line number Diff line change
Expand Up @@ -578,8 +578,8 @@ def libvirt_domain(self):

@property
def block_devices(self):
''' Return all :py:class:`qubes.storage.BlockDevice`s for current domain
for serialization in the libvirt XML template as <disk>.
''' Return all :py:class:`qubes.storage.BlockDevice` for current domain
for serialization in the libvirt XML template as <disk>.
'''
for v in self.volumes.values():
block_dev = v.block_device()
Expand Down Expand Up @@ -1029,7 +1029,7 @@ def run_service(self, service, source=None, user=None,
:param str service: service name
:param qubes.vm.qubesvm.QubesVM source: source domain as presented to
this VM
this VM
:param str user: username to run service as
:param bool filter_esc: filter escape sequences to protect terminal \
emulator
Expand Down Expand Up @@ -1199,7 +1199,7 @@ def start_daemon(*command, input=None, **kwargs):
This function take care to run it as appropriate user.
:param command: command to run (array for
:py:meth:`subprocess.check_call`)
:py:meth:`subprocess.check_call`)
:param kwargs: args for :py:meth:`subprocess.check_call`
:return: None
''' # pylint: disable=redefined-builtin
Expand Down

0 comments on commit f393ce6

Please sign in to comment.