-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qvm-start-daemon: ignore self qube for starting audio/gui daemons #285
Conversation
Do not even consider starting audio/gui daemons for local domain (like sys-gui's gui-daemon insider sys-gui itself), that doesn't make sense. Skipping it early avoids also trying to access properties guivm/audiovm doesn't have access to. QubesOS/qubes-issues#1590
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 75.06% 75.04% -0.02%
==========================================
Files 51 51
Lines 7837 7839 +2
==========================================
Hits 5883 5883
- Misses 1954 1956 +2 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024041216-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024031904-4.2&flavor=update
Failed tests28 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/94176#dependencies 47 fixed
Unstable tests
|
Do not even consider starting audio/gui daemons for local domain (like
sys-gui's gui-daemon insider sys-gui itself), that doesn't make sense.
Skipping it early avoids also trying to access properties guivm/audiovm
doesn't have access to.
QubesOS/qubes-issues#1590