Support for dynamic audiovm switching #283
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
- Coverage 75.07% 74.60% -0.47%
==========================================
Files 51 51
Lines 7811 7899 +88
==========================================
+ Hits 5864 5893 +29
- Misses 1947 2006 +59 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024042711-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024041501-4.2&flavor=update
Failed tests12 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/97064#dependencies 20 fixed
Unstable tests
|
|
This made the default |
I've not tested in dom0, I guess this is because I removed |
|
One more thing I noticed - the audiovm tries to access "guivm" property (I get a message about policy deny), even though only "audiovm" service is enabled. I haven't looked yet where it tries to access it. |
|
This should have "fixes QubesOS/qubes-issues#8966" tag in "cleanup pacat process" commit message |
|
And maybe "fixes QubesOS/qubes-issues#8975" in some other too? |
It fixes also a missing dependencies and a typo
Start only enabled services and not both.
qubesadmin/tools/qvm_start_daemon.py
Outdated
| xid, stubdom_xid = self.xid_cache[vm.name] | ||
| oldvalue = _kwargs.get("oldvalue", None) | ||
| newvalue = _kwargs.get("newvalue", None) | ||
| if oldvalue == self.app.local_name and newvalue == "None": |
There was a problem hiding this comment.
Shouldn't it be newvalue != self.app.local_name ? Right now when I change audiovm from dom0 to sys-audio, the pacat process in dom0 remains running. Or is it intentional for more reliable switching back?
There was a problem hiding this comment.
But also, this means if I first switch from sys-audio to dom0 and then shutdown the qube, its pacat remains in sys-audio (it's terminated in dom0 only).
There was a problem hiding this comment.
Shouldn't it be
newvalue != self.app.local_name? Right now when I change audiovm from dom0 to sys-audio, the pacat process in dom0 remains running. Or is it intentional for more reliable switching back?
No it's not intentional, I think it was at the very early work for this to handle all the cases in the same function without rethinking the whole after. I'll fix that indeed.
QubesOS/qubes-issues#8975