Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use less space on qvm template install (issue 8876) #278

Merged

Conversation

slayoo
Copy link
Contributor

@slayoo slayoo commented Mar 1, 2024

No description provided.

@slayoo
Copy link
Contributor Author

slayoo commented Mar 1, 2024

BTW, the changes to .pylintrc and qubesadmin/base.py are addressing pylint complains but are otherwise unrelated - can go to another PR?

@slayoo
Copy link
Contributor Author

slayoo commented Mar 2, 2024

closing & reopening, trying to trigger a CI build

@slayoo slayoo closed this Mar 2, 2024
@slayoo slayoo reopened this Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.13%. Comparing base (b2ccba7) to head (e6ce069).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   75.07%   75.13%   +0.06%     
==========================================
  Files          51       51              
  Lines        7811     7826      +15     
==========================================
+ Hits         5864     5880      +16     
+ Misses       1947     1946       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qubesos-bot
Copy link

qubesos-bot commented Mar 4, 2024

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024030513-4.2&flavor=pull-requests

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024021304-4.2&flavor=update

Failed tests

13 failures

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/91994#dependencies

16 fixed
  • system_tests_pvgrub_salt_storage

    • TC_41_HVMGrub_fedora-38-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_41_HVMGrub_fedora-38-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_42_PVHGrub_fedora-38-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_42_PVHGrub_fedora-38-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_network_updates

  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_20_AudioVM_Pulse_fedora-38-xfce-pool: test_220_audio_play_pulseaudio (failure)
      AssertionError: too short audio, expected 10s, got 9.49195011337868...
  • system_tests_basic_vm_qrexec_gui_btrfs

    • TC_20_AudioVM_Pulse_debian-12-xfce-pool: test_220_audio_play_pulseaudio (failure)
      AssertionError: too short audio, expected 10s, got 8.35183673469387...

    • TC_20_AudioVM_Pulse_fedora-38-xfce-pool: test_220_audio_play_pulseaudio (failure)
      AssertionError: too short audio, expected 10s, got 8.88408163265306...

  • system_tests_basic_vm_qrexec_gui_ext4

  • system_tests_guivm_gui_interactive

    • guivm_manager: unnamed test (unknown)
    • guivm_manager: Failed (test died)
      # Test died: no candidate needle with tag(s) 'menu-qubes-tools' mat...
  • system_tests_basic_vm_qrexec_gui

  • system_tests_basic_vm_qrexec_gui_xfs

    • TC_20_AudioVM_Pulse_debian-12-xfce-pool: test_220_audio_play_pulseaudio (failure)
      AssertionError: Command 'paplay --format=float32le --rate=44100 --c...

Unstable tests

  • system_tests_whonix

    whonix_torbrowser/ (1/5 times with errors)
    whonix_torbrowser/Failed (1/5 times with errors)
    • job 92213 # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...
  • system_tests_suspend

    suspend/Failed (1/5 times with errors)
    • job 91086 # Test died: command 'true' timed out at /usr/lib/os-autoinst/autot...
    suspend/wait_serial (1/5 times with errors)
    • job 91086 # wait_serial expected: qr/p5~T5-\d+-/...
  • system_tests_pvgrub_salt_storage

    TC_40_PVGrub_debian-12-xfce/test_000_standalone_vm (2/5 times with errors)
    • job 90533 AssertionError: Failed command: apt-get update && apt-get install -...
    • job 92022 AssertionError: Failed command: apt-get update && apt-get install -...
    TC_41_HVMGrub_debian-12-xfce/test_000_standalone_vm (2/5 times with errors)
    • job 90533 AssertionError: Failed command: apt-get update && apt-get install -...
    • job 92022 AssertionError: Failed command: apt-get update && apt-get install -...
    TC_41_HVMGrub_fedora-38-xfce/test_000_standalone_vm (4/5 times with errors)
    • job 91783 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 92022 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 92026 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 92232 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    TC_42_PVHGrub_debian-12-xfce/test_000_standalone_vm (2/5 times with errors)
    • job 90533 AssertionError: Failed command: apt-get update && apt-get install -...
    • job 92022 AssertionError: Failed command: apt-get update && apt-get install -...
    TC_42_PVHGrub_fedora-38-xfce/test_000_standalone_vm (1/5 times with errors)
    • job 92026 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    TC_10_VMSalt_debian-12-xfce/test_003_update (2/5 times with errors)
    • job 90533 AssertionError: Salt command '['qubesctl', '--skip-dom0', '--show-o...
    • job 92022 AssertionError: Salt command '['qubesctl', '--skip-dom0', '--show-o...
    TC_40_PVGrub_debian-12-xfce/test_010_template_based_vm (2/5 times with errors)
    • job 90533 AssertionError: Failed command: apt-get update && apt-get install -...
    • job 92022 AssertionError: Failed command: apt-get update && apt-get install -...
    TC_41_HVMGrub_debian-12-xfce/test_010_template_based_vm (3/5 times with errors)
    • job 90533 AssertionError: Failed command: apt-get update && apt-get install -...
    • job 91783 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 92022 AssertionError: Failed command: apt-get update && apt-get install -...
    TC_41_HVMGrub_fedora-38-xfce/test_010_template_based_vm (4/5 times with errors)
    • job 91783 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 92022 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 92026 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 92232 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    TC_42_PVHGrub_debian-12-xfce/test_010_template_based_vm (2/5 times with errors)
    • job 90533 AssertionError: Failed command: apt-get update && apt-get install -...
    • job 92022 AssertionError: Failed command: apt-get update && apt-get install -...
    TC_42_PVHGrub_fedora-38-xfce/test_010_template_based_vm (2/5 times with errors)
    • job 92022 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 92026 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
  • system_tests_usbproxy

    TC_20_USBProxy_core3_debian-12-xfce/test_060_auto_detach_on_remove (1/5 times with errors)
    • job 91059 AssertionError: 0 == 0 : Device disconnection failed
    TC_20_USBProxy_core3_whonix-gateway-17/test_070_attach_not_installed_front (1/5 times with errors)
    • job 91759 qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...
  • system_tests_network_updates

    VmUpdates_debian-12-xfce/test_000_simple_update (1/5 times with errors)
    • job 91144 AssertionError: 1 not found in [0] : set -o pipefail; apt-get updat...
    VmUpdates_debian-12-xfce/test_131_no_network_qubes_vm_update_cli (4/5 times with errors)
    • job 91144 AssertionError: qubes-vm-update return unexpected code: 0 in (1, 2)
    • job 91791 AssertionError: qubes-vm-update return unexpected code: 0 in (1, 2)
    • job 92021 AssertionError: qubes-vm-update return unexpected code: 0 in (1, 2)
    • job 92231 AssertionError: qubes-vm-update return unexpected code: 0 in (1, 2)
  • system_tests_devices

    TC_00_List_debian-12-xfce/test_001_list_loop_mounted (1/5 times with errors)
    • job 91775 AssertionError: Device test-inst-vm:loop0 (/tmp/test.img) should no...
  • system_tests_whonix@hw1

    whonix_torbrowser/ (1/5 times with errors)
    whonix_torbrowser/Failed (1/5 times with errors)
    • job 92213 # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...
  • system_tests_basic_vm_qrexec_gui_zfs

    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 91761 AssertionError: too short audio, expected 10s, got 9.13544217687074...
    • job 91798 AssertionError: too short audio, expected 10s, got 9.19061224489796...
    TC_20_AudioVM_Pulse_fedora-38-xfce-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 91798 AssertionError: too short audio, expected 10s, got 8.94136054421768...
    • job 92000 AssertionError: too short audio, expected 10s, got 9.49195011337868...
    TC_20_AudioVM_Pulse_fedora-38-xfce-pool/test_223_audio_play_hvm (1/5 times with errors)
    • job 90538 AssertionError: too short audio, expected 10s, got 9.40260770975056...
    TC_20_AudioVM_PipeWire_debian-12-xfce-pool/test_227_audio_rec_muted_pipewire (1/5 times with errors)
    • job 91761 AttributeError: 'NoneType' object has no attribute 'read'
  • system_tests_basic_vm_qrexec_gui_btrfs

    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 92011 AssertionError: too short audio, expected 10s, got 8.35183673469387...
    • job 92221 AssertionError: too short audio, expected 10s, got 8.16569160997732...
    TC_20_AudioVM_Pulse_fedora-38-xfce-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 92011 AssertionError: too short audio, expected 10s, got 8.88408163265306...
    • job 92221 AssertionError: too short audio, expected 10s, got 9.05950113378684...
    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_222_audio_rec_unmuted_pulseaudio (1/5 times with errors)
    • job 90170 qubes.exc.QubesVMError: Failed to attach audio input from dom0 to t...
    TC_20_AudioVM_PipeWire_debian-12-xfce-pool/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 92221 AssertionError: too short audio, expected 10s, got 9.43346938775510...
    TC_20_AudioVM_PipeWire_fedora-38-xfce-pool/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 92221 AssertionError: too short audio, expected 10s, got 9.48482993197278...
  • system_tests_basic_vm_qrexec_gui_ext4

    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_220_audio_play_pulseaudio (4/5 times with errors)
    • job 91773 AssertionError: too short audio, expected 10s, got 9.06770975056689...
    • job 91796 AssertionError: too short audio, expected 10s, got 9.01487528344671...
    • job 92012 AssertionError: too short audio, expected 10s, got 9.32294784580498...
    • job 92222 AssertionError: too short audio, expected 10s, got 7.86945578231292...
    TC_20_AudioVM_Pulse_fedora-38-xfce-pool/test_220_audio_play_pulseaudio (3/5 times with errors)
    • job 91796 AssertionError: too short audio, expected 10s, got 8.55206349206349...
    • job 92012 AssertionError: too short audio, expected 10s, got 8.59505668934240...
    • job 92222 AssertionError: too short audio, expected 10s, got 9.04922902494331...
    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_222_audio_rec_unmuted_pulseaudio (1/5 times with errors)
    • job 92012 qubes.exc.QubesVMError: Failed to attach audio input from dom0 to t...
    TC_20_AudioVM_PipeWire_debian-12-xfce-pool/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 91796 AssertionError: too short audio, expected 10s, got 9.41421768707483...
    TC_20_AudioVM_PipeWire_fedora-38-xfce-pool/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 91796 AssertionError: too short audio, expected 10s, got 9.44544217687074...
  • system_tests_basic_vm_qrexec_gui@hw1

    TC_20_AudioVM_Pulse_debian-12-xfce/test_220_audio_play_pulseaudio (3/5 times with errors)
    • job 91771 AssertionError: too short audio, expected 10s, got 8.76888888888888...
    • job 92010 AssertionError: too short audio, expected 10s, got 9.13582766439909...
    • job 92220 AssertionError: Command 'paplay --format=float32le --rate=44100 --c...
    TC_20_AudioVM_Pulse_fedora-38-xfce/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 91771 AssertionError: too short audio, expected 10s, got 9.33428571428571...
    • job 92010 AssertionError: too short audio, expected 10s, got 8.25360544217687...
    TC_20_AudioVM_PipeWire_debian-12-xfce/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 91771 AssertionError: too short audio, expected 10s, got 9.22444444444444...
    TC_20_AudioVM_PipeWire_fedora-38-xfce/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 92220 AssertionError: too short audio, expected 10s, got 9.49464852607709...
  • system_tests_suspend@hw1

    suspend/Failed (1/5 times with errors)
    • job 91086 # Test died: command 'true' timed out at /usr/lib/os-autoinst/autot...
    suspend/wait_serial (1/5 times with errors)
    • job 91086 # wait_serial expected: qr/p5~T5-\d+-/...
  • system_tests_splitgpg

    TC_10_Thunderbird_fedora-38-xfce/test_000_send_receive_default (1/5 times with errors)
    • job 91785 Exception: Failed to send message with error 'unknown'
    TC_10_Thunderbird_fedora-38-xfce/test_010_send_receive_inline_signed_only (3/5 times with errors)
    • job 91085 Exception: Failed to send message with error 'unknown'
    • job 91785 Exception: Failed to send message with error 'unknown'
    • job 92234 Exception: Failed to send message with error 'unknown'
  • system_tests_basic_vm_qrexec_gui

    TC_20_AudioVM_Pulse_debian-12-xfce/test_220_audio_play_pulseaudio (3/5 times with errors)
    • job 91771 AssertionError: too short audio, expected 10s, got 8.76888888888888...
    • job 92010 AssertionError: too short audio, expected 10s, got 9.13582766439909...
    • job 92220 AssertionError: Command 'paplay --format=float32le --rate=44100 --c...
    TC_20_AudioVM_Pulse_fedora-38-xfce/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 91771 AssertionError: too short audio, expected 10s, got 9.33428571428571...
    • job 92010 AssertionError: too short audio, expected 10s, got 8.25360544217687...
    TC_20_AudioVM_PipeWire_debian-12-xfce/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 91771 AssertionError: too short audio, expected 10s, got 9.22444444444444...
    TC_20_AudioVM_PipeWire_fedora-38-xfce/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 92220 AssertionError: too short audio, expected 10s, got 9.49464852607709...
  • system_tests_basic_vm_qrexec_gui_xfs

    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_220_audio_play_pulseaudio (4/5 times with errors)
    • job 91774 AssertionError: too short audio, expected 10s, got 9.48501133786848...
    • job 91797 AssertionError: too short audio, expected 10s, got 8.22698412698412...
    • job 92013 AssertionError: Command 'paplay --format=float32le --rate=44100 --c...
    • job 92223 AssertionError: too short audio, expected 10s, got 9.39870748299319...
    TC_20_AudioVM_Pulse_fedora-38-xfce-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 91774 AssertionError: too short audio, expected 10s, got 8.41195011337868...
    • job 91797 AssertionError: too short audio, expected 10s, got 9.39836734693877...

@marmarek marmarek merged commit bf188e9 into QubesOS:main Mar 8, 2024
4 checks passed
@slayoo
Copy link
Contributor Author

slayoo commented Mar 8, 2024

Thanks @marmarek !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants