Improve layout filtering of options for setxkbmap #255
Conversation
Currently options like shift_caps_switch, lctrl_rctrl_switch and other first-last layout toggles is broken because they are not be filtered out. The provided code maybe does it better. Note, that solution was not tested by me! It is just an idea how it is possible to improve fc08f4e. Docs: The list of options for keyboard layout switching is present in 'grp' chapter of `/usr/share/X11/xkb/rules`. Note: I am not sure that "while pressed" shortcuts will work or if it work now.
|
pylint complaining in CI seems unrelated to your changes |
Yes, certainly. It happened to my other PR, too: /pull/254 |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023080903-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023071104-4.2&flavor=update
Failed tests9 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/77326#dependencies 23 fixed
Unstable tests
|
|
@marmarek what does |
|
PipelineRetry |
It's just a marking to include this PR in the next test run. And actually, the test was run already and results are in a comment above. None of the failures looks related to this PR so all good :) |
Codecov Report
@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 75.12% 75.42% +0.30%
==========================================
Files 51 51
Lines 7806 8452 +646
==========================================
+ Hits 5864 6375 +511
- Misses 1942 2077 +135
|
NOT TESTED.
Currently options like shift_caps_switch, lctrl_rctrl_switch and other first-last layout toggles are broken because they are not being filtered out. The provided code maybe does it better. Note, that solution was not tested by me! It is just an idea how it is possible to improve fc08f4e.
Docs: The list of options for keyboard layout switching is present in 'grp' chapter of
/usr/share/X11/xkb/rules.Note: I am not sure that "while pressed" shortcuts will work or if they even work now.