Final part of /var/tmp monitoring during backup restore #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful for tests. QubesOS/qubes-issues#
Avoid failing restore after potentially lengthy processing - check available space first. This will be even more important after adding waiting for free space - then if there won't be enough free space, the process will deadlock. QubesOS/qubes-issues#4791
Instead of failing the restore process, pause data extracting, until already extracted data gets processed. This commit implements this for local tar extraction. Extracting data received from a VM is handled in qfile-(dom0-)unpacker, which also has similar feature, turned on in 6338b93. Fixes QubesOS/qubes-issues#4791
Storing encrypted filename into f_name shadowed unencrypted source file name.
marmarek
force-pushed
the
backup-tmp-space
branch
from
fc43e93 to
8f3158b
Compare
This test uses three tricks to test /var/tmp space monitoring: 1. Creates a big uncompressed backup (2GB file instead of few bytes) 2. Mount small tmpfs over /var/tmp (650MB - minimal space that should not deadlock the restore) 3. Artificially slow down data processing by adding sleep() QubesOS/qubes-issues#4791
marmarek
force-pushed
the
backup-tmp-space
branch
from
8f3158b to
0f42fd0
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/15656#dependencies Failed tests
New failuresCompared to: https://openqa.qubes-os.org/tests/12774#dependencies
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/12774#dependencies
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the final part - the case of restoring backup directly from dom0.
And also adds a test for this.
Fixes QubesOS/qubes-issues#4791