Cleanup Admin API denial reporting #158
Merged
+81
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename QubesDaemonNoResponseError to more intuitive QubesDaemonAccessError (keep legacy name still working). Use QubesPropertyAccessError whenever the access is about @Property - this makes it easy to use `getattr` to use default value instead. QubesOS/qubes-issues#5811
marmarek
force-pushed
the
access-error-exc
branch
from
cdf0974 to
7425a53
Compare
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 74.51% 74.37% -0.14%
==========================================
Files 50 50
Lines 6634 6681 +47
==========================================
+ Hits 4943 4969 +26
- Misses 1691 1712 +21
Continue to review full report at Codecov.
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/11232#dependencies Failed tests
New failuresCompared to: https://openqa.qubes-os.org/tests/10831#dependencies
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/10831#dependencies
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename QubesDaemonNoResponseError to more intuitive
QubesDaemonAccessError (keep legacy name still working).
Use QubesPropertyAccessError whenever the access is about @Property -
this makes it easy to use
getattrto use default value instead.QubesOS/qubes-issues#5811