Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script for GuiVM session #154

Merged
merged 3 commits into from
Aug 3, 2020
Merged

Conversation

pwmarcz
Copy link
Contributor

@pwmarcz pwmarcz commented Jul 29, 2020

See QubesOS/qubes-issues#5662.

Depends on a refactoring (and rpc service) in QubesOS/qubes-gui-agent-linux#105.

Also needs installation by Salt:

  • set qvm-feature gui-allow-fullscreen = 1,
  • add an xsession script /usr/share/xsessions/sys-gui.desktop:
[Desktop Entry]
Name=GUI Domain (sys-gui)
Exec=qubes-guivm-session sys-gui
Type=Application

pwmarcz added 3 commits July 29, 2020 11:27
Allow specifying VM names to look for.
To be used in an xsession file (/usr/share/xsessions).
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #154 into master will increase coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   74.09%   74.14%   +0.05%     
==========================================
  Files          49       49              
  Lines        6327     6328       +1     
==========================================
+ Hits         4688     4692       +4     
+ Misses       1639     1636       -3     
Impacted Files Coverage Δ
qubesadmin/tools/qvm_start_daemon.py 53.70% <50.00%> (-1.42%) ⬇️
qubesadmin/tools/qvm_run.py 80.31% <0.00%> (+2.65%) ⬆️
qubesadmin/spinner.py 77.41% <0.00%> (+6.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60d28dc...624e4e3. Read the comment docs.

@marmarek marmarek merged commit 77e1e08 into QubesOS:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants