Added some safeguards for invalid firewall rules #139
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
+ Coverage 74.74% 74.89% +0.15%
==========================================
Files 48 48
Lines 6061 6063 +2
==========================================
+ Hits 4530 4541 +11
+ Misses 1531 1522 -9
Continue to review full report at Codecov.
|
marmarta
force-pushed
the
bugfix5772
branch
2 times, most recently
from
9c1a311 to
2d9dcd7
Compare
Firewall rule cannot be missing value in declaration (e.g. 'dsthost=' is not a valid rule). fixes QubesOS/qubes-issues#5772
marmarek
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more None dsthosts or port ranges.
fixes QubesOS/qubes-issues#5772