Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GuiVM #108

Merged
merged 9 commits into from
Oct 22, 2019
Merged

GuiVM #108

merged 9 commits into from
Oct 22, 2019

Conversation

fepitre
Copy link
Member

@fepitre fepitre commented Oct 19, 2019

Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides comments in code, please separate code style change from functional changes into separate commits.

qubesadmin/tools/qvm_start_gui.py Outdated Show resolved Hide resolved
qubesadmin/tools/qvm_start_gui.py Outdated Show resolved Hide resolved
qubesadmin/tools/qvm_start_gui.py Outdated Show resolved Hide resolved
qubesadmin/tools/qvm_start_gui.py Outdated Show resolved Hide resolved
qubesadmin/tools/qvm_start_gui.py Outdated Show resolved Hide resolved
qubesadmin/tools/qvm_start_gui.py Outdated Show resolved Hide resolved
qubesadmin/tools/qvm_start_gui.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 20, 2019

Codecov Report

Merging #108 into master will decrease coverage by 0.11%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   74.83%   74.71%   -0.12%     
==========================================
  Files          47       47              
  Lines        5749     5766      +17     
==========================================
+ Hits         4302     4308       +6     
- Misses       1447     1458      +11
Impacted Files Coverage Δ
qubesadmin/tools/qvm_start_gui.py 59.92% <47.05%> (-1.33%) ⬇️
qubesadmin/app.py 86.89% <85.71%> (-0.1%) ⬇️
qubesadmin/spinner.py 77.41% <0%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e6e2f...03bc15d. Read the comment docs.

@fepitre fepitre changed the title WIP: guivm GuiVM Oct 20, 2019
@marmarek marmarek merged commit 03bc15d into QubesOS:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants