Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock: bind mount qubes-pesign socket on build #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

mock: bind mount qubes-pesign socket on build #77

wants to merge 2 commits into from

Conversation

fepitre
Copy link
Member

@fepitre fepitre commented Nov 16, 2023

marmarek
marmarek reviewed Dec 1, 2023
View reviewed changes
qubesbuilder/plugins/chroot_rpm/mock/fedora.cfg Outdated
@@ -17,6 +17,10 @@ config_opts['use_bootstrap'] = False
config_opts['plugin_conf']['bind_mount_enable'] = os.environ.get("BIND_MOUNT_ENABLE", False)
config_opts['plugin_conf']['bind_mount_opts']['dirs'].append(('@BUILDER_DIR@/plugins', '/plugins' ))

# mount the pesign socket into the chroot
config_opts['plugin_conf']['bind_mount_opts']['dirs'].append(('/var/run/qubes-pesign', '/var/run/qubes-pesign' ))
config_opts['nspawn_args'] += ['--bind=/var/run/qubes-pesign']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't those two meaning the same thing? Why both are needed?

Copy link
Member Author

@fepitre fepitre Dec 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've copy pasted some snippet in a thread but I've tested and only the second one is needed.

@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.03%. Comparing base (63809ee) to head (58bd259).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   76.62%   78.03%   +1.41%     
==========================================
  Files          47       47              
  Lines        5317     5317              
==========================================
+ Hits         4074     4149      +75     
+ Misses       1243     1168      -75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fepitre fepitre changed the title mock: bind mount pesign socket on build mock: bind mount qubes-pesign socket on build Dec 2, 2023
@fepitre fepitre mentioned this pull request Dec 10, 2023
Closed
DemiMarie
DemiMarie reviewed Dec 22, 2023
View reviewed changes
rpc/qubes.PESign Outdated Show resolved Hide resolved
@marmarek
Copy link
Member

marmarek commented Jan 9, 2024

@fepitre what is the recommended method for redirecting /var/run/qubes-pesign to qrexec? socat started in /rw/config/rc.local? systemd .socket unit? Can you document it somewhere (README here? or in vmm-xen-unified repo?) ?

fepitre added a commit to QubesOS/qubes-vmm-xen-unified that referenced this pull request Aug 2, 2024
@fepitre
Update README
27a4537 
QubesOS/qubes-builderv2#77
@fepitre
Copy link
Member Author

fepitre commented Aug 7, 2024

@fepitre what is the recommended method for redirecting /var/run/qubes-pesign to qrexec? socat started in /rw/config/rc.local? systemd .socket unit? Can you document it somewhere (README here? or in vmm-xen-unified repo?) ?

Doc is in vmm-xen-unified repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DemiMarie DemiMarie DemiMarie left review comments

@marmarek marmarek marmarek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fepitre @marmarek @DemiMarie