Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out minor block headers with larger create time #780

Merged
merged 5 commits into from
Oct 28, 2019

Conversation

hanyunx
Copy link
Contributor

@hanyunx hanyunx commented Oct 28, 2019

@hanyunx hanyunx requested a review from a team October 28, 2019 18:20
Copy link
Contributor

@ninjaahhh ninjaahhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root_state.validate_block will fail line 1274

@hanyunx hanyunx requested a review from ninjaahhh October 28, 2019 20:46
@@ -1270,6 +1270,7 @@ def handle_new_root_block_header(self, header, peer):
self.root_state.write_committing_hash(r_block.header.get_hash())

adjusted_diff = await self.__adjust_diff(r_block)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove in the next commit (if any).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it!

@hanyunx hanyunx merged commit 5310b34 into master Oct 28, 2019
@hanyunx hanyunx deleted the minor-block-time branch October 28, 2019 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants