Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JEQB #196: Keyring account #26

Merged
merged 3 commits into from
Jan 25, 2023
Merged

JEQB #196: Keyring account #26

merged 3 commits into from
Jan 25, 2023

Conversation

Wolmin
Copy link

@Wolmin Wolmin commented Jan 16, 2023

This PR provides fixes for dilithium2 keyring account generations

@Wolmin Wolmin self-assigned this Jan 16, 2023
@Wolmin Wolmin added the enhancement New feature or request label Jan 16, 2023
leoni-q
leoni-q reviewed Jan 25, 2023
View reviewed changes
Copy link

@leoni-q leoni-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix all GitHub Actions/ Build repository warnings

primitives/keyring/src/dilithium2.rs Show resolved Hide resolved
@Wolmin Wolmin requested a review from leoni-q January 25, 2023 11:05
@Wolmin Wolmin merged commit c14400a into qmc-v0.0.1 Jan 25, 2023
@Wolmin Wolmin deleted the stanislaw/jeqb-196/keyring-account branch January 25, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoni-q leoni-q leoni-q approved these changes

@kostiask kostiask Awaiting requested review from kostiask

@zedleppelin74 zedleppelin74 Awaiting requested review from zedleppelin74

Assignees

@Wolmin Wolmin

Labels
A0-pleasereview enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wolmin @leoni-q