Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #406 #409

Merged
merged 10 commits into from
Sep 24, 2021
Merged

Fix #406 #409

merged 10 commits into from
Sep 24, 2021

Conversation

tbenthompson
Copy link
Collaborator

Closes #406.

Checklist

  • Added a CHANGELOG.rst entry

lbittarello
lbittarello approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@lbittarello lbittarello left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, Ben!

As a separate issue, we're still casting sparse penalties to dense when expanding them. It might be worth revisiting.

CHANGELOG.rst Outdated Show resolved Hide resolved
@lbittarello
Copy link
Member

lbittarello commented Sep 24, 2021 •
edited
Loading

The original fix didn't work for string penalties (e.g., "identity"), because it applied np.asarray before calling _expand_categorical_penalties. I took the liberty of moving that snippet. Feel free to revert!

@tbenthompson tbenthompson mentioned this pull request Sep 24, 2021
Open
@tbenthompson
Copy link
Collaborator Author

The original fix didn't work string penalties (e.g., "identity"), because it applied np.asarray before calling _expand_categorical_penalties. I took the liberty of moving that snippet. Feel free to revert!

Thanks Luca!

@tbenthompson tbenthompson merged commit 53acb49 into master Sep 24, 2021
@tbenthompson tbenthompson deleted the fix-406 branch September 24, 2021 18:09
tbenthompson added a commit that referenced this pull request Oct 8, 2021
@tbenthompson @lbittarello
Fix #406 (#409)
3836716 
* Fix #406

* Add changelog entry.

* Add changelog entry.

* Move check inside _expand_categorical_penalties

* Remove glmnet_python.

* Changelog.

* Remove changelog entry since the bug was introduced after the previous release.

Co-authored-by: lbittarello <[email protected]>
tbenthompson added a commit that referenced this pull request Oct 8, 2021
@tbenthompson @lbittarello
Fix #406 (#409)
fb335ee 
* Fix #406

* Add changelog entry.

* Add changelog entry.

* Move check inside _expand_categorical_penalties

* Remove glmnet_python.

* Changelog.

* Remove changelog entry since the bug was introduced after the previous release.

Co-authored-by: lbittarello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbittarello lbittarello lbittarello approved these changes

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC Awaiting requested review from MarcAntoineSchmidtQC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sparse penalty matrices raise an out-of-bounds error
2 participants
@tbenthompson @lbittarello