Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pypi flag behavior #37

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Fix pypi flag behavior #37

merged 2 commits into from
Feb 14, 2025

Conversation

PaulKMueller
Copy link
Collaborator

Motivation

The default behavior by clap is to set arguments with action = ArgAction::SetTrue to Some(value).
While sensible in some contexts, this breaks some of our checks.

Changes

The osi and ignore-pypi flags now need to be specified like so:
--ignore-pypi false

Copy link
Member

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bump the version here to 0.4.0?

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (9e4f0c3) to head (eeacaa2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   84.25%   88.58%   +4.33%     
==========================================
  Files          12       12              
  Lines         508      508              
==========================================
+ Hits          428      450      +22     
+ Misses         80       58      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulKMueller PaulKMueller enabled auto-merge (squash) February 14, 2025 11:13
@PaulKMueller PaulKMueller merged commit 2dd024f into main Feb 14, 2025
16 checks passed
@PaulKMueller PaulKMueller deleted the fix branch February 14, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants