Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bayes_nonconj] Remove pyro code from bayes_nonconj #15

Merged
merged 2 commits into from
Mar 1, 2024
Merged

[bayes_nonconj] Remove pyro code from bayes_nonconj #15

merged 2 commits into from
Mar 1, 2024

Conversation

kp992
Copy link
Contributor

@kp992 kp992 commented Feb 10, 2024

Fixes #13

cc @mmcky

Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for timely-seahorse-68815c ready!

Name Link
🔨 Latest commit d6129a6
🔍 Latest deploy log https://app.netlify.com/sites/timely-seahorse-68815c/deploys/65d313c88b93950008c597d5
😎 Deploy Preview https://deploy-preview-15--timely-seahorse-68815c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kp992
Copy link
Contributor Author

kp992 commented Feb 10, 2024

@mmcky Can you please test it if there are no clashes between JAX/torch GPU? Many thanks.

Copy link

github-actions bot commented Feb 10, 2024

@github-actions github-actions bot temporarily deployed to pull request February 10, 2024 13:54 Inactive
@kp992 kp992 requested a review from mmcky February 11, 2024 06:44
@mmcky
Copy link
Contributor

mmcky commented Feb 19, 2024

@kp992 exceptional work on removing pyro.

It actually has simplified the code a lot.

I will ask @thomassargent30 to take a look at the preview https://65c7800b5289ee700011359b--timely-seahorse-68815c.netlify.app/bayes_nonconj

@mmcky
Copy link
Contributor

mmcky commented Feb 19, 2024

@thomassargent30 -- when setting up this series of lectures, we found that this lecture bayes_nonconj used jax and pytorch which causes major issues when using the same software environment -- which is why even on https://python.quantecon.org/bayes_nonconj.html it was computing using a cpu. Essentially torch and jax seem incompatible due to conflicts in a mix of CUDA / GPU driver versions and therefore require different drivers which can't be done in the same software environment.

@kp992 has done a great job of removing torch and focusing this lecture just on jax which removes the dependency on torch.

Would you be able to review

https://65c7800b5289ee700011359b--timely-seahorse-68815c.netlify.app/bayes_nonconj

when you have time.

This should fix the last major technical issue in the reorg project.

@github-actions github-actions bot temporarily deployed to pull request February 19, 2024 09:13 Inactive
@mmcky mmcky changed the title Remove pyro code from bayes_nonconj [bayes_nonconj] Remove pyro code from bayes_nonconj Feb 19, 2024
@mmcky
Copy link
Contributor

mmcky commented Mar 1, 2024

thanks @kp992 and @thomassargent30. Merging this now.

@mmcky mmcky merged commit 0fdd2b8 into main Mar 1, 2024
7 checks passed
@mmcky mmcky deleted the i13 branch March 1, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bayes_nonconj] Migrate from pytorch to just use JAX
2 participants