Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIGRATE: pandas_panel lecture from stats #310

Merged
merged 6 commits into from
May 1, 2024
Merged

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Apr 30, 2024

This PR migrates pandas_panel from lecture-stats

fixes #303

Copy link

github-actions bot commented Apr 30, 2024

@github-actions github-actions bot temporarily deployed to pull request April 30, 2024 02:44 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Apr 30, 2024

There are a few deprecation notices that should be addressed

  • fix dataframe deprecation
FutureWarning: DataFrame.groupby with axis=1 is deprecated. Do `frame.T.groupby(...)` without axis instead.
  merged.groupby(level='Continent', axis=1).mean().head()
  • fix seaborn deprecation
/home/runner/miniconda3/envs/quantecon/lib/python3.11/site-packages/seaborn/_oldcore.py:1119: FutureWarning: use_inf_as_na option is deprecated and will be removed in a future version. Convert inf values to NaN before operating instead.

@github-actions github-actions bot temporarily deployed to pull request April 30, 2024 23:59 Inactive
Copy link
Contributor Author

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstac are you happy for this to be merged.

The main changes to the incoming lecture are captured in caaacae

@jstac
Copy link
Contributor

jstac commented May 1, 2024

Thanks @mmcky . I'm a little busy but perhaps @shlff could provide a second set of eyes?

I'll leave you to merge when ready.

@mmcky
Copy link
Contributor Author

mmcky commented May 1, 2024

Thanks @shlff the only real changes being applied are to fix deprecation notices in pandas in caaacae otherwise this is just migrating the lecture from it's old location.

@shlff
Copy link
Member

shlff commented May 1, 2024

I see. Thanks @mmcky .

I quickly went through the lecture:

  • the two depreciation notices have been fixed, and
  • all links are working well.

This lecture looks good to me so I reckon it is ready to be merged.

@mmcky
Copy link
Contributor Author

mmcky commented May 1, 2024

thanks @shlff -- greatly appreciate the second set of eyes.

@mmcky mmcky merged commit 8518c8b into main May 1, 2024
5 checks passed
@mmcky mmcky deleted the migrate-pandas-panel branch May 1, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate pandas_panel to this lecture series
3 participants