-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use np.interp instead of interpolation.interp #156
Conversation
@mmcky and @HumphreyYang , could you please do a first round review of this? The aim is that swapping to NumPy's interp does not change results or degrade performance. |
Note that this is related to QuantEcon/lecture-python.myst#387 |
Thanks @kp992. The last dependency on
@kp992 any scope to be able to remove interpolations as a dependency -- otherwise maybe we need to solve EconForge/interpolation.py#110 re: |
Thanks for the review @mmcky.
Yeah, I checked that. Its the only one left with
Hmm, I will check with some scipy functions and if possible remove it in a follow-up PR. |
@kp992 the lecture |
@mmcky Thanks for pointing out the issue. The CI is green. |
thanks @kp992 Just documenting this is now the only use case of
|
This PR replaces all the occurences of
interpolation.interp
tonp.interp
now thatnumba
supportsnp.interp
directly.