Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QuantEcon.next_k_array! in support_enumeration #82

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Use QuantEcon.next_k_array! in support_enumeration #82

merged 1 commit into from
Jun 1, 2018

Conversation

monsij
Copy link
Contributor

@monsij monsij commented May 29, 2018

Closes issue #70
The remaining changes have been made mentioned in the comment-link. Kindly let me know if the changes in docstrings are also required.
@sglyon @oyamad

@oyamad
Copy link
Member

oyamad commented Jun 1, 2018

@monsij Thanks.

  • Yes, please delete the docstrings of _next_k_combination and _next_k_array!.
  • Please do not delete blank lines in other docstrings. See the changes you made.

@codecov-io
Copy link

codecov-io commented Jun 1, 2018

Codecov Report

Merging #82 into master will increase coverage by 3.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   92.52%   96.43%   +3.91%     
==========================================
  Files           6        6              
  Lines         468      449      -19     
==========================================
  Hits          433      433              
+ Misses         35       16      -19
Impacted Files Coverage Δ
src/support_enumeration.jl 100% <ø> (+21.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b921342...5453b2b. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 1, 2018

Coverage Status

Coverage increased (+3.9%) to 96.437% when pulling 5453b2b on monsij:support_enumeration into b921342 on QuantEcon:master.

@monsij
Copy link
Contributor Author

monsij commented Jun 1, 2018

It's done ! 🎉 @oyamad @sglyon

@oyamad
Copy link
Member

oyamad commented Jun 1, 2018

Great, thanks!

@oyamad oyamad merged commit 9835700 into QuantEcon:master Jun 1, 2018
@monsij
Copy link
Contributor Author

monsij commented Jun 1, 2018

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants