Fix: not save non interactive user properties #488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not for now |
Romazes
deleted the
fix-461-not-save-non-interactive-parameter-in-lean-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the configuration parameter passed in non-interactive mode, such as
--tradier-environment paper, is not saved in thelean.jsonfile. The fix ensures that these parameters are properly recorded, regardless of whether Lean is run in interactive or non-interactive mode.Related Issue
Closes #461
Motivation and Context
The issue was identified when running Lean in non-interactive mode. Users who passed configuration parameters, like
--tradier-environment paper, noticed that these were not being saved in thelean.jsonfile. This behavior was inconsistent with the expected functionality, as in interactive mode, parameters were saved correctly.This PR corrects the behavior, ensuring that configuration parameters are consistently saved across both interactive and non-interactive modes. This change improves the user experience by maintaining consistency and ensuring that user preferences are retained for future use.
How Has This Been Tested?
run in 2 ways:
lean live deploy mynewalgo-> save in configuration file;lean live deploy mynewalgo --data-provider-live tradier --tradier-environment live-> save in configuration file.