Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 479 no update command #485

Merged

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Aug 13, 2024

Description

This update modifies the behavior of module versioning, making it dependent on the lean_version specified within the container. For example, if the container is set with lean_version = 2.5.16563, then when specifying a data provider, such as --data-provider-historical Alpaca, the corresponding version of the Alpaca module will be downloaded that matches this specific lean_version.

Related Issue

Closes #479

Motivation and Context

This change is crucial for maintaining version consistency across the project. By tying the module versions directly to the lean_version, we ensure that all components—such as data providers like Alpaca—are using the appropriate versions that are compatible with the specified lean_version. This reduces the risk of incompatibilities and streamlines the module management process.

How Has This Been Tested?

lean research

In advance, I have create custom 🐳 research image with labels:

...
"Labels": {
    "lean_version": "16563"
    ...
}
...
  • lean research mynewalgo --data-provider-historical alpaca
    image

lean backtest

  • lean backtest mynewalgo --data-provider-historical alpaca
    image

lean data download

  • lean data download --data-provider-historical alpaca --data-type trade --resolution daily --security-type Equity --ticker AAPL --start 20240101 --end 20240801
    image

lean live deploy

  • lean live deploy mynewalgo --brokerage "Paper Trading" --data-provider-live "Alpaca"
    image

  • lean live deploy mynewalgo --brokerage "Paper Trading" --data-provider-live "Interactive Brokers"

    • use latest version of image 2.5.16567 🐳 without label lean_version.
      image
  • lean live deploy mynewalgo --brokerage "Interactive Brokers" --data-provider-live "Kraken"

We use custom version of container with label look at screen bellow. Also, we have downloaded last available version of QuantConnect.Brokerages.InteractiveBrokers.ToolBox.2.5.16550.

image

  • lean live deploy mynewalgo --brokerage "Coinbase Advanced Trade" --data-provider-live "Kraken"

use latest version of container 🐳 without label

image

  • lean live deploy mynewalgo --brokerage "Coinbase Advanced Trade" --data-provider-live "Kraken"

We have used label version bigger than available package in cloud. It's mean, we will use maximum available package in cloud <=

image

  • lean live deploy mynewalgo --brokerage "Interactive Brokers" --data-provider-live "Kraken" --verbose

add log debug message.

image

@Romazes Romazes added bug Something isn't working feature labels Aug 13, 2024
@Romazes Romazes self-assigned this Aug 13, 2024
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@Martin-Molinero Martin-Molinero merged commit 8590aad into QuantConnect:master Aug 15, 2024
28 checks passed
@Romazes Romazes deleted the fix-479-download-no-update-command branch September 17, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NO UPDATE Command Enforces Updates
2 participants