-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 479 no update command #485
Merged
Martin-Molinero
merged 10 commits into
QuantConnect:master
from
Romazes:fix-479-download-no-update-command
Aug 15, 2024
Merged
Fix 479 no update command #485
Martin-Molinero
merged 10 commits into
QuantConnect:master
from
Romazes:fix-479-download-no-update-command
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce with actual download one
refactor: use module_version like required parameter
…hat we return last one version
Martin-Molinero
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update modifies the behavior of module versioning, making it dependent on the
lean_version
specified within the container. For example, if the container is set withlean_version = 2.5.16563
, then when specifying a data provider, such as --data-provider-historical Alpaca, the corresponding version of the Alpaca module will be downloaded that matches this specificlean_version
.Related Issue
Closes #479
Motivation and Context
This change is crucial for maintaining version consistency across the project. By tying the module versions directly to the
lean_version
, we ensure that all components—such as data providers like Alpaca—are using the appropriate versions that are compatible with the specifiedlean_version
. This reduces the risk of incompatibilities and streamlines the module management process.How Has This Been Tested?
lean research
In advance, I have create custom 🐳 research image with labels:
lean research mynewalgo --data-provider-historical alpaca
lean backtest
lean backtest mynewalgo --data-provider-historical alpaca
lean data download
lean data download --data-provider-historical alpaca --data-type trade --resolution daily --security-type Equity --ticker AAPL --start 20240101 --end 20240801
lean live deploy
lean live deploy mynewalgo --brokerage "Paper Trading" --data-provider-live "Alpaca"
lean live deploy mynewalgo --brokerage "Paper Trading" --data-provider-live "Interactive Brokers"
2.5.16567
🐳 without labellean_version
.lean live deploy mynewalgo --brokerage "Interactive Brokers" --data-provider-live "Kraken"
lean live deploy mynewalgo --brokerage "Coinbase Advanced Trade" --data-provider-live "Kraken"
lean live deploy mynewalgo --brokerage "Coinbase Advanced Trade" --data-provider-live "Kraken"
lean live deploy mynewalgo --brokerage "Interactive Brokers" --data-provider-live "Kraken" --verbose