Fix get last portfolio holdings bug #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marinovsky
force-pushed
the
bug-471-FixGetLastPortfolioHoldings
branch
from
8179e01 to
f768854
Compare
- Since you must always choose a data feed when deploying a local live algo, data_provider_live will never be zero. - Since the date used to determine the last local deployment (in live_utils.py get_last_portfolio) comes from the output directory, we cannot create the output directory before calling get_last_portfolio because then we would get always the local holdings in the get_last_portfolio_method - The output directory for the previous state file (see _get_last_portfolio) comes with an "L-" prefix
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the continuation of this draft: #473. Some endpoints were deprecated and the names for some properties were in capital case instead of camel case. The following test cases were proved (using PaperBrokerage and InteractiveBrokers Brokerage):
Regarding the bug #468 , this bug was fixed adding
projectIdin the response fromlive/read, updating the call to theQCFullLiveAlgorithmconstructor and removing some attributes unused from this same class