-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Downloader Data Provider #423
Closed
Romazes
wants to merge
31
commits into
QuantConnect:master
from
Romazes:fix-configure-data-provider-in-live
Closed
Optional Downloader Data Provider #423
Romazes
wants to merge
31
commits into
QuantConnect:master
from
Romazes:fix-configure-data-provider-in-live
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add new config of CoinApi * feat: CoinApi configs for backtest/research/optimize
refactor: assertion in test with different version of py
refactor: assertion in test with different version of py
…com/Romazes/lean-cli into fix-configure-data-provider-in-live
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We stumbled upon impossible to subscribe on data provider live and historical in the same time.
Result
Nowadays, we can use 2 command in the same time without exception. The fix is downloaded packages and create dependency references. Additionaly we have opportunity to combine our
live
andhistorical
providers in different way, look at example bellow ⬇ we uselive
provider iexcloud.io andhistorical
polygon.io--data-provider-live IEX
- iexcloud.io data provider--data-provider-historical Polygon
- polygon.io data providerIf
--data-provider-live
doesn't have historical oportunityFor istance:
The Bybit doesn't have historical option like provider that's mean it will use
Local
provider by default:Like this
Feature (user friendly)
If user subscribe on
--data-provider-live
without--data-provider-historical
then the code is using the smaedata-provider-historical
likelive
if it is exsist.For instance:
Testing
Test Algorithm:
First command:
lean live deploy --brokerage "Paper Trading" --data-provider-live IEX --data-provider-historical Polygon Project
First Result img:
Second command:
lean live deploy --brokerage "Paper Trading" --data-provider-live IEX Project
Second Result img:
Third command:
lean live deploy --brokerage "Paper Trading" --data-provider-live IEX --data-provider-historical Local IEXAlgo
Third Result img:
Fourth command:
lean live deploy --brokerage "Coinbase Advanced Trade" --data-provider-live "Coinbase Advanced Trade" CoinApiAlgo
Fourth img:
Fifth command:
If don't have key in our
config.json
lean live deploy --brokerage "Paper Trading" --data-provider-live IEX --data-provider-historical Polygon IEXAlgo
Fifth img: