More fixes and improvements

QuantConnect · May 2, 2024 · b5f50a0 · b5f50a0
1 parent 8ed68ae
commit b5f50a0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -880,14 +880,14 @@ Options:
   --dataset TEXT                  The name of the dataset to download non-interactively
   --overwrite                     Overwrite existing local data
   -y, --yes                       Automatically confirm payment confirmation prompts
-  --data-type [Trade|Quote|OpenInterest]
+  --data-type [Trade|Quote|Bulk|OpenInterest]
                                   Specify the type of historical data
   --resolution [Tick|Second|Minute|Hour|Daily]
                                   Specify the resolution of the historical data
   --security-type [Equity|Index|Forex|Cfd|Future|Crypto|CryptoFuture|Option|IndexOption|Commodity|FutureOption]
                                   Specify the security type of the historical data
   --market TEXT                   Specify the market name for tickers (e.g., 'USA', 'NYMEX', 'Binance')
-  --tickers TEXT                  Specify comma separated list of tickers to use for historical data request.
+  --ticker TEXT                   Specify comma separated list of tickers to use for historical data request.
   --start-date TEXT               Specify the start date for the historical data request in the format yyyyMMdd.
   --end-date TEXT                 Specify the end date for the historical data request in the format yyyyMMdd. (defaults
                                   to today)

diff --git a/lean/commands/data/download.py b/lean/commands/data/download.py
@@ -513,7 +513,7 @@ def _configure_date_option(date_value: str, option_id: str, option_label: str) -
     help="Specify the security type of the historical data")
 @option("--market", type=str,
         help="Specify the market name for tickers (e.g., 'USA', 'NYMEX', 'Binance')")
-@option("--tickers",
+@option("--ticker",
         type=str,
         help="Specify comma separated list of tickers to use for historical data request.")
 @option("--start-date",
@@ -544,7 +544,7 @@ def download(ctx: Context,
              resolution: Optional[str],
              security_type: Optional[str],
              market: Optional[str],
-             tickers: Optional[str],
+             ticker: Optional[str],
              start_date: Optional[str],
              end_date: Optional[str],
              image: Optional[str],
@@ -576,6 +576,9 @@ def download(ctx: Context,
     """
     organization = _get_organization()
 
+    if dataset:
+        data_provider_historical = 'QuantConnect'
+
     if data_provider_historical is None:
         data_provider_historical = _get_historical_data_provider()
 
@@ -627,12 +630,12 @@ def download(ctx: Context,
         market = _get_user_input_or_prompt(market, data_provider_support_markets,
                                            data_provider_historical, "Select a Market")
 
-        if not tickers:
-            tickers = ','.join(DatasetTextOption(id="id",
-                               label="Enter comma separated list of tickers to use for historical data request.",
-                               description="description",
-                               transform=DatasetTextOptionTransform.Lowercase,
-                               multiple=True).configure_interactive().value)
+        if not ticker:
+            ticker = ','.join(DatasetTextOption(id="id",
+                                                label="Enter comma separated list of tickers to use for historical data request.",
+                                                description="description",
+                                                transform=DatasetTextOptionTransform.Lowercase,
+                                                multiple=True).configure_interactive().value)
 
         start_date = _configure_date_option(start_date, "start", "Please enter a Start Date in the format")
         end_date = _configure_date_option(end_date, "end", "Please enter a End Date in the format")
@@ -680,7 +683,7 @@ def download(ctx: Context,
                          "--security-type", security_type,
                          "--market", market,
                          "--resolution", resolution,
-                         "--tickers", tickers]
+                         "--tickers", ticker]
 
         run_options["commands"].append(' '.join(dll_arguments))