Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance command support #8348

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

Martin-Molinero
Copy link
Member

@Martin-Molinero Martin-Molinero commented Sep 30, 2024

Description

  • Enhance command support, adding link helper methods. Adding and expanding new tests
  • Minor improvement for command str representation

Related Issue

See #8330

Motivation and Context

Requires Documentation Change

N/A

How Has This Been Tested?

Existing and new tests, live deployments

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

- Enhance command support, adding link helper methods. Adding and
  expanding new tests
- Minor improvement for command str representation
@Martin-Molinero Martin-Molinero force-pushed the refactor-command-link-helper branch from ac5a3e6 to 3917e87 Compare September 30, 2024 17:18
@Martin-Molinero Martin-Molinero merged commit 8fb70b2 into master Sep 30, 2024
11 of 14 checks passed
@Martin-Molinero Martin-Molinero deleted the refactor-command-link-helper branch September 30, 2024 19:01
wtindall1 pushed a commit to wtindall1/Lean that referenced this pull request Nov 10, 2024
* Enhance command support

- Enhance command support, adding link helper methods. Adding and
  expanding new tests
- Minor improvement for command str representation

* Minor test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant