Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoinApi Extraction: Removing from Lean.ToolBox #7777

Merged

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Feb 12, 2024

Description

This pull request addresses the removal of the CoinApi component from the Lean.ToolBox project. The intention is to migrate this functionality into an independent project, thereby improving modularity and code organization.

  • Removal of CoinApi Code:
    • Removed all CoinApi-related code, modules, and dependencies from the Lean.ToolBox project.
  • Refactoring:
    • Refactored the codebase to ensure that the removal of CoinApi does not introduce any compilation errors or unexpected behavior.

Related Issue

N/A

Related PR

Lean.DataSource.CoinAPI

Motivation and Context

The decision to extract the CoinAPI functionality into a standalone project is driven by the desire to enhance maintainability and promote a cleaner separation of concerns within the codebase. This will allow for easier maintenance and future updates to the CoinAPI integration, as well as better support for alternative data providers.

Requires Documentation Change

N/A

How Has This Been Tested?

Run all exsiting Unit Tests in repo.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Ty 🚀

we have removed all IDataQueueHandler from ToolBox
@Martin-Molinero Martin-Molinero merged commit 1dd186a into QuantConnect:master Feb 13, 2024
6 checks passed
@Romazes Romazes deleted the remove-coin-api-toolbox-program branch February 21, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants