This repository has been archived by the owner on Jan 3, 2025. It is now read-only.
IEX Project Refactoring and Enhancement #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neat: add readability
bonus: change debug msg
feat: use DRY principle change: input param from typeOf to Enum feat: create reuseable method
… Get() feat: add test of IEXDataDownloader
feat: subscribe on 2 different channel (Last Trade & Top of Book) feat: new Entities for channels refactor: logic of handle of update from Channels remove: not used tests
feat: process of creation new client feat: sync context test: data feed more clearly test.fix: name class in Downloader
feat: update DataQueueHandler UTest
feat: add description to variable test: rewrite long running test
11 tasks
remove: IEXDownloader proj
…ketHours remove: Validation for resolutions less than a second; the current implementation also supports tick resolution
refactor: Enhance logging messages
feat: Add validation for incorrect date range (start >= end) fix: Change assertion to a more appropriate exception type
fix: Resolution minute can return more than 30 days in GetHistory feat: add UTests
refactor: Get IEXPricePlan amount
commits: #2c672799454ee82223968d0df997db45748f1fc1 && #9a48d4f8a14753bf68184340772e602540123aec
refactor: test with subs a lot of symbols
remove: extra trt\catch block
fix: skip unnecessary date in GetHistory() feat: add test to GetHistory long period data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pull request concentrates on refining and enhancing the IEX project. Major changes involve integrating IEX Cloud into an independent project with a clear structure, removing unused code, significantly reducing unnecessary code using modern programming principles, and enhancing tests for the DataQueueHandler process. Other noteworthy improvements include optimizing subscription processes, introducing a two-channel data feed, and updating dependencies. The primary objective is to enhance code structure, improve functionality, and streamline the project for better maintainability.
Related Issue
N/A
Related PR
Lean PR
Lean-cli PR
Motivation and Context
The primary motivation behind this pull request is to carry out a comprehensive refactoring and enhancement of the IEX project. The changes aim to improve code structure, readability, and functionality. The move from Lean to a new independent repository is also part of this effort.
Requires Documentation Change
Yes, this pull request requires documentation updates to reflect the changes made to the IEX project.
How Has This Been Tested?
The changes have been thoroughly tested to ensure the stability and correctness of the IEX project. This includes testing for each of the features, refactored code sections, and newly added functionalities. Additionally, the workflow file has been prepared to automate and streamline the testing process.
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>