Enhancing AlphaVantage Data Source Integration #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: create solution file
feat: handle several exception fix: req param feat: create new live UTests rename: mock file
feat: new test cases
remove: limit 2 year for minute\hour request
fix: mock unit tests feat: warning on 25req/day for live tests
feat: comment flag to not show extra log in Action pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces significant changes to the project, primarily focusing on extracting the Lean.ToolBox module and establishing a new, dedicated GitHub repository for it. Simultaneously, it incorporates improvements to the integration with the AlphaVantage data source to enhance data retrieval and result accuracy.
Related Issue
N/A
Related PR
Lean PR
Lean-cli PR
Motivation and Context
The primary motivation is to modularize the codebase by extracting the Lean.ToolBox module, transforming it into an independent solution hosted in a new GitHub repository. This separation streamlines maintenance, fosters reusability, and promotes better organization within the project.
The AlphaVantage data source integration has been refined to address issues related to data retrieval. By leveraging the new repository, the project can now utilize the improved AlphaVantage module to obtain more accurate and reliable results.
Requires Documentation Change
No modifications to the existing documentation are necessary with this pull request.
How Has This Been Tested?
The changes have undergone rigorous testing, encompassing various scenarios. Valid test cases for different resolution types (minute, hour, daily) have been executed to ensure the correct functioning of the data retrieval process. Additionally, a multitude of invalid test cases, featuring incorrect request data, have been incorporated to fortify error handling. The existing mock test cases have been reviewed and adjusted to guarantee the robustness of the implemented changes.
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>