Minor refactoring based on static analysis on the code of *ROIAlign: (p…

…ytorch#2892) - Remove unnecessary return.
Quansight · Dec 4, 2020 · 2fb53d4 · 2fb53d4
1 parent 6d2d9d8
commit 2fb53d4
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 8 deletions.
diff --git a/torchvision/csrc/cpu/PSROIAlign_cpu.cpp b/torchvision/csrc/cpu/PSROIAlign_cpu.cpp
@@ -194,8 +194,6 @@ void bilinear_interpolate_gradient(
   // T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);
 
   w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;
-
-  return;
 }
 
 template <class T>

diff --git a/torchvision/csrc/cpu/ROIAlign_cpu.cpp b/torchvision/csrc/cpu/ROIAlign_cpu.cpp
@@ -269,8 +269,6 @@ void bilinear_interpolate_gradient(
   // T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);
 
   w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;
-
-  return;
 }
 
 template <class T>

diff --git a/torchvision/csrc/cuda/PSROIAlign_cuda.cu b/torchvision/csrc/cuda/PSROIAlign_cuda.cu
@@ -192,8 +192,6 @@ __device__ void bilinear_interpolate_gradient(
   // T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);
 
   w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;
-
-  return;
 }
 
 template <typename T>

diff --git a/torchvision/csrc/cuda/ROIAlign_cuda.cu b/torchvision/csrc/cuda/ROIAlign_cuda.cu
@@ -194,8 +194,6 @@ __device__ void bilinear_interpolate_gradient(
   // T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);
 
   w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;
-
-  return;
 }
 
 template <typename T>
-Original file line number
+Diff line change
@@ Expand Up / @@ -194,8 +194,6 @@ void bilinear_interpolate_gradient( @@
       // T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);
       w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;
-      return;
     }
     template <class T>
@@ Expand Down @@