Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: -e to type (#29) #40

Merged
merged 2 commits into from
Jun 3, 2021
Merged

refactor: -e to type (#29) #40

merged 2 commits into from
Jun 3, 2021

Conversation

KEINOS
Copy link
Member

@KEINOS KEINOS commented Jun 3, 2021 •
edited
Loading

Issue #29 の -e および which を type に統一するだけの PR。

@KEINOS KEINOS added the WIP There is a draft PR for this label Jun 3, 2021
@KEINOS KEINOS mentioned this pull request Jun 3, 2021
Closed
@KEINOS KEINOS marked this pull request as ready for review June 3, 2021 09:03
@KEINOS KEINOS self-assigned this Jun 3, 2021
@KEINOS KEINOS removed the WIP There is a draft PR for this label Jun 3, 2021
@KEINOS
Copy link
Member Author

KEINOS commented Jun 3, 2021

簡単なリファクタですが、お手すきにレビューお願いしまーす。

waiting_for_lgtm

@KEINOS KEINOS force-pushed the issue29-uniform-which-to-type branch from 13d1542 to 71f99e4 Compare June 3, 2021 09:14
@KEINOS
Copy link
Member Author

KEINOS commented Jun 3, 2021

PR #41 の変更を反映（rebase）しました

@yoshi389111
Copy link
Collaborator

確認しました。問題ありません。

LGTM

@KEINOS KEINOS merged commit dde7df6 into Qithub-BOT:master Jun 3, 2021
@KEINOS KEINOS deleted the issue29-uniform-which-to-type branch June 3, 2021 09:25
@KEINOS KEINOS mentioned this pull request Jun 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KEINOS KEINOS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KEINOS @yoshi389111