Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive の修正 #16

Merged
merged 2 commits into from
May 27, 2021
Merged

archive の修正 #16

merged 2 commits into from
May 27, 2021

Conversation

yoshi389111
Copy link
Collaborator

気になったものを修正しました。

  • ファイル先頭のコメントおよび usage メッセージの修正
  • 秘密鍵ファイルを作成する際に umask 077 をして、group/otherに読み込み権限をつけない
  • 秘密鍵の読み込み時の条件が逆転していた( #3 shellcheck(静的解析)と shfmt(lint)の実装 #13 のレビューの確認もれでした。すみません)

@KEINOS
Copy link
Member

KEINOS commented May 27, 2021

ありがとうございます!

#14 の動作テスト(予定)にアクセス権のチェックも入れたほうが良さそうですね。

obama_drunk

マージいたし 💪

@KEINOS KEINOS merged commit 0d6543b into Qithub-BOT:master May 27, 2021
@yoshi389111 yoshi389111 deleted the fix_archive branch May 28, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants