Add Katz Centrality #797
Merged
Add Katz Centrality #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5139295387
💛 - Coveralls |
mtreinish
reviewed
May 30, 2023
rustworkx-core/src/centrality.rs
Outdated
| for node_index in graph.node_identifiers() { | ||
| let node = graph.to_index(node_index); | ||
| if !beta.contains_key(&node) { | ||
| return Ok(None); // beta_map was provided but did not include all nodes |
There was a problem hiding this comment.
Should this be an error instead of None? It feels like a user error if they pass in a mapping that's incomplete here.
There was a problem hiding this comment.
None means it’s not defined… it map to an error in Python but in Rust we let the caller handle it
mtreinish
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #441
Add the Katz centrality to both rustworkx and rustworkx-core. I mostly forked the code from
eigenvector_centralityand made the adaptations