Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add induced kwarg in is_subgraph_isomorphic #372

Merged
merged 7 commits into from
Jun 24, 2021

Conversation

georgios-ts
Copy link
Collaborator

This commit adds a kwarg induced in is_subgraph_isomorphic to determine if we should check for a node-induced subgraph or not induced. Previously, only node-induced case was supported.
In not induced case, the changes are minimal: we shouldn't check R_new pruning rule and check neighbors in R_suc and R_pred rules only in the second graph.

@coveralls
Copy link

coveralls commented Jun 23, 2021

Pull Request Test Coverage Report for Build 967643698

  • 41 of 42 (97.62%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 97.517%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/isomorphism.rs 33 34 97.06%
Totals Coverage Status
Change from base Build 960868250: 0.007%
Covered Lines: 8168
Relevant Lines: 8376

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise this LGTM, it's a relatively simple change. Just a few minor docs issues then I think this is good to go.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
retworkx/__init__.py Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
georgios-ts and others added 3 commits June 24, 2021 10:39
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM< thanks for updating so quickly. There is one nit inline, but not worth blocking anything over.

@mtreinish mtreinish merged commit bd74316 into Qiskit:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants