-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add induced kwarg in is_subgraph_isomorphic
#372
Add induced kwarg in is_subgraph_isomorphic
#372
Conversation
Pull Request Test Coverage Report for Build 967643698
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise this LGTM, it's a relatively simple change. Just a few minor docs issues then I think this is good to go.
Co-authored-by: Matthew Treinish <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM< thanks for updating so quickly. There is one nit inline, but not worth blocking anything over.
This commit adds a kwarg
induced
inis_subgraph_isomorphic
to determine if we should check for a node-induced subgraph or not induced. Previously, only node-induced case was supported.In not induced case, the changes are minimal: we shouldn't check
R_new
pruning rule and check neighbors inR_suc
andR_pred
rules only in the second graph.