Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Local Complementation #1366

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Conversation

S-Erik
Copy link
Contributor

@S-Erik S-Erik commented Jan 17, 2025

See #1365.

Any comments on the tests, documentation and the error handling are welcome.

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Jan 18, 2025

Pull Request Test Coverage Report for Build 12998721628

Details

  • 38 of 38 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 95.819%

Totals Coverage Status
Change from base Build 12940380885: 0.008%
Covered Lines: 18381
Relevant Lines: 19183

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making your first contribution! It is very welcome, this seems to be a more niche function and that is fine. rustworkx has plenty of methods that are more Quantum Computing centric let's say.

I did leave comments and there are still some TODOs:

Lastly, I can do this for you when I merge the code but feel free to do it yourself if you want:

rustworkx/__init__.py Outdated Show resolved Hide resolved
src/connectivity/mod.rs Outdated Show resolved Hide resolved
src/connectivity/mod.rs Outdated Show resolved Hide resolved
tests/graph/test_local_complement.py Outdated Show resolved Hide resolved
tests/graph/test_local_complement.py Outdated Show resolved Hide resolved
src/connectivity/mod.rs Outdated Show resolved Hide resolved
src/connectivity/mod.rs Outdated Show resolved Hide resolved
tests/graph/test_local_complement.py Show resolved Hide resolved
src/connectivity/mod.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@IvanIsCoding IvanIsCoding added this to the 0.17.0 milestone Jan 19, 2025
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, this is ready to be merged!

@IvanIsCoding IvanIsCoding added this pull request to the merge queue Jan 28, 2025
Merged via the queue into Qiskit:main with commit c4e9432 Jan 28, 2025
31 checks passed
@S-Erik S-Erik deleted the local_complementation branch January 28, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants