-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Local Complementation #1366
Conversation
Assure multigraphs are not allowed and local complementation is not defined for digraphs. Self loops are assumed to not exist in the provided grahps. Added test
|
Pull Request Test Coverage Report for Build 12998721628Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making your first contribution! It is very welcome, this seems to be a more niche function and that is fine. rustworkx
has plenty of methods that are more Quantum Computing centric let's say.
I did leave comments and there are still some TODOs:
- Adding type annotations, the CI is failing because they are missing https://github.com/Qiskit/rustworkx/blob/main/CONTRIBUTING.md#type-annotations
- Sign the CLA
Lastly, I can do this for you when I merge the code but feel free to do it yourself if you want:
- Adding release notes https://github.com/Qiskit/rustworkx/blob/main/CONTRIBUTING.md#release-notes
- Add your method to the documentation somewhere in https://github.com/Qiskit/rustworkx/tree/main/docs/source/api
…igraph_local_complement, add&improve tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, this is ready to be merged!
See #1365.
Any comments on the tests, documentation and the error handling are welcome.