-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PyO3 to 0.22 #1293
Update PyO3 to 0.22 #1293
Conversation
Ok, this is ready just pending PyO3/rust-numpy#453. Update: it worked fine after #1292 without issues |
Pull Request Test Coverage Report for Build 11331133743Details
💛 - Coveralls |
Ok this is ready to go |
I think there is a bug in PyO3 0.22.4 released today (https://github.com/PyO3/pyo3/blob/release-0.22/CHANGELOG.md). Our code compiles with 0.22.3 but fails with 0.22.4. We should probably merge this as is an open an issue?
|
It is confirmed 0.22.4 has a regression: PyO3/pyo3#4616 We can bump to 0.22.5 once it is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except for one small stray comment inline which I'll apply and re-approve for. Thanks for doing this. I agree we should update to 0.22.5 and remove py-clone in a follow-up PR.
Closes #1250
This depends on:
rust-numpy
releasing 0.22, which will happen soon. For the time being, we build from their Git main branchpy-clone
feature is enabled, if it is disabled too many things failThe update brokeSlicing is now fixediterators.rs
, I haven't had the time to fix so for this draft I just deleted support for slicing. Of course the final version will need to reintroduce itWe have 68 warnings! But hey it buildsWarnings are fixedI also profited from this PR to update
ndarray
andndarray-stats
.For
py-clone
I think we should handle it in a future PR