Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add musl aarch64 support at tier 4 #1008

Merged
merged 10 commits into from
Nov 4, 2023

Conversation

IvanIsCoding
Copy link
Collaborator

Follow up to #992 and #997

This adds support for musl aarch64 wheels.

The wheels are unstested because of QEMU and NumPy. QEMU takes around 30+ minutes per Python version to build rustworkx. NumPy doesn't provide wheels for this architecture, hence adding tests would balloon the time considerably just to compile NumPy.

After #891, we can improve this architecture support by adding tests

@IvanIsCoding IvanIsCoding added this to the 0.14.0 milestone Oct 18, 2023
@coveralls
Copy link

coveralls commented Oct 18, 2023

Pull Request Test Coverage Report for Build 6749011978

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.546%

Totals Coverage Status
Change from base Build 6728247109: 0.0%
Covered Lines: 15680
Relevant Lines: 16241

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, I left some comments inline on the first job, but they apply to both jobs. Also did you spin up a test to make sure the build works? It'd be good to get confirmation the config will build the packages at least (since this stuff can be really finicky).

.github/workflows/wheels.yml Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
@IvanIsCoding
Copy link
Collaborator Author

I launched a test workflow at https://github.com/IvanIsCoding/rustworkx/actions/runs/6684576474 for this

@IvanIsCoding
Copy link
Collaborator Author

I had to re-launch to exclude manylinux from musllinux builds, here are the new workflow executions: https://github.com/IvanIsCoding/rustworkx/actions/runs/6684898467/job/18162625960 and https://github.com/IvanIsCoding/rustworkx/actions/runs/6684898467/job/18162625929

@IvanIsCoding
Copy link
Collaborator Author

@mtreinish this is ready to merge I confirmed the jobs built the wheels we wanted:

rustworkx-0.14.0-cp310-cp310-musllinux_1_1_aarch64.whl   2,046 kB
rustworkx-0.14.0-cp38-cp38-musllinux_1_1_aarch64.whl     2,046 kB
rustworkx-0.14.0-cp39-cp39-musllinux_1_1_aarch64.whl     2,046 kB

and

  rustworkx-0.14.0-cp311-cp311-musllinux_1_1_aarch64.whl   2,046 kB
  rustworkx-0.14.0-cp312-cp312-musllinux_1_1_aarch64.whl   2,045 kB

The job shows as failed because it didn't have the credentials to upload to PyPI. But everything is fine

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates and testing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants