-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add musl aarch64 support at tier 4 #1008
Add musl aarch64 support at tier 4 #1008
Conversation
Pull Request Test Coverage Report for Build 6749011978
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, I left some comments inline on the first job, but they apply to both jobs. Also did you spin up a test to make sure the build works? It'd be good to get confirmation the config will build the packages at least (since this stuff can be really finicky).
Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
I launched a test workflow at https://github.com/IvanIsCoding/rustworkx/actions/runs/6684576474 for this |
I had to re-launch to exclude |
@mtreinish this is ready to merge I confirmed the jobs built the wheels we wanted:
and
The job shows as failed because it didn't have the credentials to upload to PyPI. But everything is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the updates and testing this.
Follow up to #992 and #997
This adds support for musl aarch64 wheels.
The wheels are unstested because of QEMU and NumPy. QEMU takes around 30+ minutes per Python version to build rustworkx. NumPy doesn't provide wheels for this architecture, hence adding tests would balloon the time considerably just to compile NumPy.
After #891, we can improve this architecture support by adding tests