Rename edge_list arg with edgelist to be compatible with networkx
#341
Comments
|
This was my fault when I ported the mpl drawer from networkx to retworkx in #304 I explicitly changed |
|
I see. |
|
Ok sure, I'll push another PR updating the |
mtreinish
added a commit
to mtreinish/retworkx
that referenced
this issue
May 28, 2021
This commit adds a section to the retworkx for networkx users guide on visualizations. This is important especially for the ``mpl_draw`` function since it's mostly identical to the ``networkx_drawer`` function but there are some key differences to keep in mind. This commit also makes small change to the graphviz drawer, the name of the function is renamed from `pydot_draw` to `graphviz_draw` and the Python module is renamed from `pydot` to `graphviz`. This was done to be more descriptive as graphviz is the backend not pydot. It also makes it easier to migrate away from pydot in the future if we needed to since the key piece is using graphviz not a particular python interface to it. Fixes Qiskit#341
mtreinish
added a commit
to mtreinish/retworkx
that referenced
this issue
May 28, 2021
This commit adds a section to the retworkx for networkx users guide on visualizations. This is important especially for the ``mpl_draw`` function since it's mostly identical to the ``networkx_drawer`` function but there are some key differences to keep in mind. This commit also makes small change to the graphviz drawer, the name of the function is renamed from `pydot_draw` to `graphviz_draw` and the Python module is renamed from `pydot` to `graphviz`. This was done to be more descriptive as graphviz is the backend not pydot. It also makes it easier to migrate away from pydot in the future if we needed to since the key piece is using graphviz not a particular python interface to it. Fixes Qiskit#341
mtreinish
added a commit
that referenced
this issue
May 29, 2021
* Add visualization to retworkx for networkx users guide This commit adds a section to the retworkx for networkx users guide on visualizations. This is important especially for the ``mpl_draw`` function since it's mostly identical to the ``networkx_drawer`` function but there are some key differences to keep in mind. This commit also makes small change to the graphviz drawer, the name of the function is renamed from `pydot_draw` to `graphviz_draw` and the Python module is renamed from `pydot` to `graphviz`. This was done to be more descriptive as graphviz is the backend not pydot. It also makes it easier to migrate away from pydot in the future if we needed to since the key piece is using graphviz not a particular python interface to it. Fixes #341 * Update release note too * Rename optional target to graphviz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the expected enhancement?
mpl_drawhas an argumentedge_listhttps://github.com/Qiskit/retworkx/blob/885f2de1588dc983591563f94b2ddcada443b3b2/retworkx/visualization/matplotlib.py#L101The same argument has name
edgelistin networkxhttps://networkx.org/documentation/stable/reference/generated/networkx.drawing.nx_pylab.draw_networkx_edges.html
Related to qiskit-community/qiskit-optimization#150
The text was updated successfully, but these errors were encountered: