Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated links to use sphinx-ext-linkcode to create links #589

Closed

Conversation

melechlapson
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2024

CLA assistant check
All committers have signed the CLA.

@Eric-Arellano
Copy link
Collaborator

Thanks! CI failed because you needed to run tox -e fmt. #590 fixes the other CI issues.

Btw, in case this wasn't clear, we don't want to actually merge this PR. This PR was an experiment to see how the extension works. So don't be alarmed that this doesn't get merged. It still was super helpful to open up. I'm writing up next steps on Qiskit/documentation#517.

Btw one tip for open source work: it's useful in your PR description to give more context about what's going on, like linking to Qiskit/documentation#517.

@melechlapson
Copy link
Author

Thanks for the tips. I figured that this wasn't really going to be merged so I didn't add a description or link the issues.

@Eric-Arellano
Copy link
Collaborator

This has been implemented in Runtime and Provider, so closing because this experiment did its job. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants