Some links became blue in 1.12.0rc1 #335
Assignees
Labels
bug
Something isn't working
Comments
Eric-Arellano
added a commit
that referenced
this issue
May 17, 2023
Closes #335. I git bisected this to #292. Before, we weren't actually fully running `theme.js` because JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class `.has-code`, but after they did. I suspect `theme.js` is responsible for that (but I couldn't figure out how!) Either way, these rules about `.has-code` are bad. We should not be setting links to be blue.
Eric-Arellano
added a commit
to Eric-Arellano/qiskit_sphinx_theme
that referenced
this issue
May 17, 2023
Closes Qiskit#335. I git bisected this to Qiskit#292. Before, we weren't actually fully running `theme.js` because JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class `.has-code`, but after they did. I suspect `theme.js` is responsible for that (but I couldn't figure out how!) Either way, these rules about `.has-code` are bad. We should not be setting links to be blue.
HuangJunye
pushed a commit
that referenced
this issue
May 18, 2023
Closes #335. I git bisected this to #292. Before, we weren't actually fully running `theme.js` because JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class `.has-code`, but after they did. I suspect `theme.js` is responsible for that (but I couldn't figure out how!) Either way, these rules about `.has-code` are bad. We should not be setting links to be blue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some links are now blue
when they were purple or gray before:
It seems to only affect links that are code-related:
These
<a>elements gained thehas-codeclass in 1.12.0rc1, which turned them a different color.The text was updated successfully, but these errors were encountered: