-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the BIPMapping transpiler pass in favor of external plugin #9924
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
This commit deprecates the BIPMapping transpiler pass. Since its introduction the pass has been in a weird state since it's introduction. It is a standalone transpiler pass that we never integrated it into transpile() because it has an external dependency on cplex which is a proprietary software package that most people don't have access too. With the introduction of the transpiler stage plugin interface the pass has been turned into an external package: https://github.com/qiskit-community/qiskit-bip-mapper By using the plugin interface the pass can now be cleanly integrates into the transpile() function and also makes the requirement to have cplex installed much more explicit. For users with cplex it's much easier to run the BIPMapping pass as part of a transpilation workflow with `transpile(..., routing_method="bip")`. Closes Qiskit#8662
Pull Request Test Coverage Report for Build 4633952693
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with moving the |
…iskit#9924) * Deprecate the BIPMapping transpiler pass in favor of external plugin This commit deprecates the BIPMapping transpiler pass. Since its introduction the pass has been in a weird state since it's introduction. It is a standalone transpiler pass that we never integrated it into transpile() because it has an external dependency on cplex which is a proprietary software package that most people don't have access too. With the introduction of the transpiler stage plugin interface the pass has been turned into an external package: https://github.com/qiskit-community/qiskit-bip-mapper By using the plugin interface the pass can now be cleanly integrates into the transpile() function and also makes the requirement to have cplex installed much more explicit. For users with cplex it's much easier to run the BIPMapping pass as part of a transpilation workflow with `transpile(..., routing_method="bip")`. Closes Qiskit#8662 * Catch deprecation warnings in tests * Fix lint
…iskit#9924) * Deprecate the BIPMapping transpiler pass in favor of external plugin This commit deprecates the BIPMapping transpiler pass. Since its introduction the pass has been in a weird state since it's introduction. It is a standalone transpiler pass that we never integrated it into transpile() because it has an external dependency on cplex which is a proprietary software package that most people don't have access too. With the introduction of the transpiler stage plugin interface the pass has been turned into an external package: https://github.com/qiskit-community/qiskit-bip-mapper By using the plugin interface the pass can now be cleanly integrates into the transpile() function and also makes the requirement to have cplex installed much more explicit. For users with cplex it's much easier to run the BIPMapping pass as part of a transpilation workflow with `transpile(..., routing_method="bip")`. Closes Qiskit#8662 * Catch deprecation warnings in tests * Fix lint
Summary
This commit deprecates the BIPMapping transpiler pass. Since its introduction the pass has been in a weird state since it's introduction. It is a standalone transpiler pass that we never integrated it into transpile() because it has an external dependency on cplex which is a proprietary software package that most people don't have access too. With the introduction of the transpiler stage plugin interface the pass has been turned into an external package:
https://github.com/qiskit-community/qiskit-bip-mapper
By using the plugin interface the pass can now be cleanly integrates into the transpile() function and also makes the requirement to have cplex installed much more explicit. For users with cplex it's much easier to run the BIPMapping pass as part of a transpilation workflow with
transpile(..., routing_method="bip")
.Details and comments
Closes #8662