Enable no-value-for-parameters (pylint)

[ikkoham]

Summary

Related to #9614

Details and comments

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Cryoris
• @Qiskit/terra-core
• @manoelmarques
• @woodsp-ibm

[coveralls]

Pull Request Test Coverage Report for Build 4240927292

• 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
• 5 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.02%) to 85.273%

---

Files with Coverage Reduction	New Missed Lines	%
qiskit/primitives/utils.py	1	90.41%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py	1	94.93%
qiskit/pulse/library/waveform.py	3	91.67%

Totals
Change from base Build 4239901762:	-0.02%
Covered Lines:	67180
Relevant Lines:	78782

---

💛 - Coveralls

[jakelishman]

I might actually be tempted to put line-level suppressions on each of these in order to remove the option from .pylintrc (which I definitely agree we should do), because these lines look like a pylint bug to me. __new__ is a special-cased staticmethod, not a classmethod like Pylint is suggesting it is, and it should be valid to use self or super() to access it.

[jakelishman]

I actually went over to Pylint to file this, to discover that Ikko had already done so: pylint-dev/pylint#8325.

[ikkoham]

@jakelishman Yes, I am sorry for the delay. After making this PR, I was thinking about the specs and started to suspect a bug, sorry to have to go through this twice. Sorry to make you take the time to look into it.

[Eric-Arellano]

Thank you for taking a look! +1 on line-level suppressions with # pylint: disable=no-value-for-parameter so that we can enable the check globally

[jakelishman]

No need to apologise! I'm totally on board with wanting this check back, and it's fun that we've found another pylint bug from Terra.

[ikkoham]

Close since it's not a priority.