Fix VQD for k>2
#8989
Merged
Fix VQD for k>2
#8989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure the optimal circuits from previous iterations are only constructed once and recognizable by the primitive caches.
Cryoris
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3335346877
💛 - Coveralls |
mtreinish
added
stable backport potential
woodsp-ibm
reviewed
Oct 25, 2022
Cryoris
commented
Oct 26, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 27, 2022
* Fix vqd for k>2 Also ensure the optimal circuits from previous iterations are only constructed once and recognizable by the primitive caches. * Remove empty parameter list Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit aab18fc)
mergify bot
added a commit
that referenced
this pull request
Oct 27, 2022
* Fix vqd for k>2 Also ensure the optimal circuits from previous iterations are only constructed once and recognizable by the primitive caches. * Remove empty parameter list Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit aab18fc) Co-authored-by: Julien Gacon <[email protected]>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8982 by fixing a bug where the optimal parameters were passed as dictionary instead of list, as expected by the estimator.
Details and comments
Also ensure the optimal circuits from previous iterations are only constructed once and recognizable by the primitive caches.
(Also fix documentation-OCD by uppercasing every letter in the beginning of a sentence.)