Add missing variable width operations to standard_gate_name_mapping() #8935
Conversation
In Qiskit#8852 we added support to the target class for representing variable width operations by using the class directly instead of an instance. Now that we have settled on a representation for these types of operations we can add them to the built in name mapping function (from which they were previously excluded. This commit adds the built-in variable width operations to the output of the function and returns just the class instead of an instance.
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this: |
|
I was originally thinking we should backport this, but since it's arguably an API change for the function (since it'll return a class for the variable width ops instead of an instance) so I don't think we should. |
| from qiskit.circuit.parameter import Parameter | ||
| from qiskit.circuit.measure import Measure | ||
| from qiskit.circuit.delay import Delay | ||
| from qiskit.circuit.reset import Reset | ||
| from qiskit.circuit.controlflow import IfElseOp, WhileLoop, ForLoop |
There was a problem hiding this comment.
I'm not really certain we should be returning these as "standard gates"; they're no gates, and they don't really follow a standard form of accepting n float-like parameters.
I suppose it depends a bit on how the result of this function is meant to be used.
There was a problem hiding this comment.
Yeah, I was on the fence about this too, but we already had Delay, Reset, etc here. This was added in #8759 so we had a mapping for basis_gate entries to object for a target. I guess the function name isn't great and we should rename it (well, alias, then deprecate, then rename).
…structions-to-circuit-table
Summary
In #8852 we added support to the target class for representing variable width operations by using the class directly instead of an instance. Now that we have settled on a representation for these types of operations we can add them to the built in name mapping function (from which they were previously excluded. This commit adds the built-in variable width operations to the output of the function and returns just the class instead of an instance.
Details and comments