Fix single-bit-condition equality in QuantumCircuit and DAGCircuit #8930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `condition` of a given operation would not be converted into bit indices in order do the semantic-equality checking that the rest of the qargs and cargs get in a circuit. This caused loose-bit comparisons to produce false negatives.
jakelishman
added
stable backport potential
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3275508694
💛 - Coveralls |
mtreinish
reviewed
Oct 18, 2022
Co-authored-by: Matthew Treinish <[email protected]>
mtreinish
approved these changes
Oct 18, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
…8930) * Fix single-bit-condition equality in QuantumCircuit and DAGCircuit Previously, the `condition` of a given operation would not be converted into bit indices in order do the semantic-equality checking that the rest of the qargs and cargs get in a circuit. This caused loose-bit comparisons to produce false negatives. * Improve temporary variable names Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 3bebd0f)
mergify bot
added a commit
that referenced
this pull request
Oct 18, 2022
…8930) (#8943) * Fix single-bit-condition equality in QuantumCircuit and DAGCircuit Previously, the `condition` of a given operation would not be converted into bit indices in order do the semantic-equality checking that the rest of the qargs and cargs get in a circuit. This caused loose-bit comparisons to produce false negatives. * Improve temporary variable names Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 3bebd0f) Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the
conditionof a given operation would not be converted into bit indices in order do the semantic-equality checking that the rest of the qargs and cargs get in a circuit. This caused loose-bit comparisons to produce false negatives.Details and comments