Fix BarrierBeforeFinalMeasurements with loose bits
#8924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We simply need to consider loose bits as well when constructing the new DAG layer. This isn't `DAGCircuit.copy_empty_like` because we don't want things like metadata and global phase.
jakelishman
added
stable backport potential
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3269945879
💛 - Coveralls |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
We simply need to consider loose bits as well when constructing the new DAG layer. This isn't `DAGCircuit.copy_empty_like` because we don't want things like metadata and global phase. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 64c5eb6)
ajavadia
pushed a commit
to ajavadia/qiskit
that referenced
this pull request
Oct 18, 2022
We simply need to consider loose bits as well when constructing the new DAG layer. This isn't `DAGCircuit.copy_empty_like` because we don't want things like metadata and global phase. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Oct 18, 2022
We simply need to consider loose bits as well when constructing the new DAG layer. This isn't `DAGCircuit.copy_empty_like` because we don't want things like metadata and global phase. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 64c5eb6) Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We simply need to consider loose bits as well when constructing the new DAG layer. This isn't
DAGCircuit.copy_empty_likebecause we don't want things like metadata and global phase.Details and comments
Fix #8923.