-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pending deprecate algorithms #8703
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3137726780
💛 - Coveralls |
releasenotes/notes/pending-deprecate-min-eigen-solvers-fa4341e1014e4df0.yaml
Outdated
Show resolved
Hide resolved
…1014e4df0.yaml Co-authored-by: Steve Wood <[email protected]>
LGTM like #8651 lets get the new algos merged and merge this afterwards. |
Just a minor comment: if there's no merge conflicts and no test failures, there's no need to "update branch" - the bot will automatically handle it efficiently when the PR is tagged for merge, and in the interim, doing it jams CI for other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primitive versions replacing these now pending deprecated algos have been merged so this can be merged now too.
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
* Pending deprecate algorithms * Update releasenotes/notes/pending-deprecate-min-eigen-solvers-fa4341e1014e4df0.yaml Co-authored-by: Steve Wood <[email protected]> Co-authored-by: Steve Wood <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Pending deprecate algorithms * Update releasenotes/notes/pending-deprecate-min-eigen-solvers-fa4341e1014e4df0.yaml Co-authored-by: Steve Wood <[email protected]> Co-authored-by: Steve Wood <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
Details and comments