Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending deprecate algorithms #8703

Merged
merged 11 commits into from
Sep 27, 2022
Merged

Pending deprecate algorithms #8703

merged 11 commits into from
Sep 27, 2022

Conversation

manoelmarques
Copy link
Member

Summary

Details and comments

@manoelmarques manoelmarques added the mod: algorithms Related to the Algorithms module label Sep 7, 2022
@manoelmarques manoelmarques self-assigned this Sep 7, 2022
@manoelmarques manoelmarques requested review from a team and woodsp-ibm as code owners September 7, 2022 17:20
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Sep 7, 2022

Pull Request Test Coverage Report for Build 3137726780

  • 27 of 27 (100.0%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 84.452%

Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/squ.py 2 79.78%
qiskit/pulse/library/waveform.py 3 91.49%
Totals Coverage Status
Change from base Build 3137724188: -0.002%
Covered Lines: 59873
Relevant Lines: 70896

💛 - Coveralls

@woodsp-ibm woodsp-ibm added this to the 0.22 milestone Sep 12, 2022
@woodsp-ibm
Copy link
Member

LGTM like #8651 lets get the new algos merged and merge this afterwards.

@woodsp-ibm woodsp-ibm added the Changelog: Deprecation Include in "Deprecated" section of changelog label Sep 16, 2022
@jakelishman
Copy link
Member

Just a minor comment: if there's no merge conflicts and no test failures, there's no need to "update branch" - the bot will automatically handle it efficiently when the PR is tagged for merge, and in the interim, doing it jams CI for other PRs.

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primitive versions replacing these now pending deprecated algos have been merged so this can be merged now too.

@jakelishman
Copy link
Member

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 293ab43 into Qiskit:main Sep 27, 2022
@manoelmarques manoelmarques deleted the deprecation branch October 27, 2022 20:15
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
* Pending deprecate algorithms

* Update releasenotes/notes/pending-deprecate-min-eigen-solvers-fa4341e1014e4df0.yaml

Co-authored-by: Steve Wood <[email protected]>

Co-authored-by: Steve Wood <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
* Pending deprecate algorithms

* Update releasenotes/notes/pending-deprecate-min-eigen-solvers-fa4341e1014e4df0.yaml

Co-authored-by: Steve Wood <[email protected]>

Co-authored-by: Steve Wood <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog mod: algorithms Related to the Algorithms module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants